fix(deps): update engines to v2.26.0-13.a9966aa784861dee7e6b2a90950874cbaf7b4984 #7796

renovate · 2021-06-21T18:41:39Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
@prisma/engines	`2.26.0-7.473f96e8dcb29039719059f8e9ac32c14a63a9f6` -> `2.26.0-13.a9966aa784861dee7e6b2a90950874cbaf7b4984`
@prisma/engines-version	`2.26.0-7.473f96e8dcb29039719059f8e9ac32c14a63a9f6` -> `2.26.0-13.a9966aa784861dee7e6b2a90950874cbaf7b4984`

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

Jolg42 · 2021-06-22T07:49:41Z

Result of prisma/prisma-engines#1945

Integration will be done with #7620

Jolg42 · 2021-06-23T11:02:39Z

src/packages/sdk/src/__tests__/__snapshots__/engineCommands.test.ts.snap

@@ -3765,7 +3765,7 @@ Object {
              "authorId",
            ],
            "relationName": "PostToUser",
-            "relationOnDelete": "NONE",
+            "relationOnDelete": "Cascade",


This should be related to prisma/prisma-engines#1947 (comment)

Not sure about the other changes, could you check @williamluke4 @millsp ?

We need to double check why the relationOnDelete changed even when the preview feature is not enabled. This will affect users potentially now.

@pimeys gave me context that this is not used in Prisma anywhere.

I just checked the community generators, none use relationOnDelete in code as well.

I think only Amplication is using it in code https://github.com/amplication/prisma-schema-dsl/blob/d7126f3ea580090bb287be34258fc13b00db6149/src/builders.ts#L169-L198

Jolg42 · 2021-06-23T11:15:46Z

src/packages/sdk/src/__tests__/migrateEngineCommands.test.ts

-               0: sql_migration_connector::flavour::postgres::create_database
-                       with self=PostgresFlavour { url: \\"<REDACTED>\\" }
-                         at migration-engine/connectors/sql-migration-connector/src/flavour/postgres.rs:117"
+            Please make sure your database server is running at \`doesnotexist\`:\`5432\`."


These 2 changes are expected ✅

janpio · 2021-06-23T13:30:37Z

src/packages/sdk/src/__tests__/__snapshots__/engineCommands.test.ts.snap

+exports[`getDMMF chinook introspected schema 1`] = `842348`;

-exports[`getDMMF chinook introspected schema connectOrCreate 1`] = `842601`;
+exports[`getDMMF chinook introspected schema connectOrCreate 1`] = `842348`;


What's this?

The size/length of a JSON stringified dmmf...

Not super useful like this to know what changed...!

prisma/src/packages/sdk/src/__tests__/engineCommands.test.ts

Lines 177 to 199 in 2226db9

test('chinook introspected schema', async () => {

const file = fs.readFileSync(

path.join(__dirname, '../../fixtures/chinook.prisma'),

'utf-8',

)

const dmmf = await getDMMF({

datamodel: file,

})

const str = JSON.stringify(dmmf)

expect(str.length).toMatchSnapshot()

})

test('chinook introspected schema connectOrCreate', async () => {

const file = fs.readFileSync(

path.join(__dirname, '../../fixtures/chinook.prisma'),

'utf-8',

)

const dmmf = await getDMMF({

datamodel: file,

})

const str = JSON.stringify(dmmf)

expect(str.length).toMatchSnapshot()

})

The length of the stringify dmmf 😕

You can give toMatchSnapshot() a string as single param, then it uses that to name the snapshot. But 🤷

janpio · 2021-06-23T13:31:21Z

src/packages/sdk/src/__tests__/__snapshots__/engineCommands.test.ts.snap

-            Object {
-              "inputTypes": Array [
-                Object {
-                  "isList": false,
-                  "location": "scalar",
-                  "type": "Int",
-                },
-                Object {
-                  "isList": false,
-                  "location": "inputObjectTypes",
-                  "namespace": "prisma",
-                  "type": "IntFieldUpdateOperationsInput",
-                },
-              ],
-              "isNullable": false,
-              "isRequired": false,
-              "name": "id",
-            },


What is causing this?

We are currently investigating

These are expected changes as this test does not have a datasource. Meaning that these operations are not supported. cc @dpetrick

Also, the gh ui is a bit screwed up here. Probably due to the large size of the file. Basically, the snapshot indicated is incorrect. It is not getDMMF model with autoincrement should fail if mysql but actually getDMMF simple model

src/packages/sdk/src/__tests__/__snapshots__/engineCommands.test.ts.snap

janpio

Looks good generally, the removals from the snapshots make me nervous though (see comments).

…4cbaf7b4984

Jolg42

We want to make the snapshot file smaller in a separate PR because it got over +30k lines 😓
#7829

…4cbaf7b4984 (prisma#7796) Co-authored-by: William Luke <william@ordino.ai> Co-authored-by: Joël Galeran <galeran@prisma.io>

renovate bot requested review from Jolg42, millsp and williamluke4 as code owners June 21, 2021 18:41

renovate-approve bot approved these changes Jun 21, 2021

View reviewed changes

renovate bot changed the title ~~fix(deps): update engines to v2.26.0-7.473f96e8dcb29039719059f8e9ac32c14a63a9f6~~ fix(deps): update engines to v2.26.0-8.a06ab528db16c04bc97ae9edf08d6dcbfa7ce889 Jun 22, 2021

renovate bot force-pushed the renovate/engines branch 2 times, most recently from fe88cfd to 771261f Compare June 22, 2021 17:10

renovate bot changed the title ~~fix(deps): update engines to v2.26.0-8.a06ab528db16c04bc97ae9edf08d6dcbfa7ce889~~ fix(deps): update engines to v2.26.0-10.4778706e0163559cd391ce644ab95c9a48b369ea Jun 22, 2021

renovate bot force-pushed the renovate/engines branch from 771261f to 3710f88 Compare June 22, 2021 18:12

renovate bot changed the title ~~fix(deps): update engines to v2.26.0-10.4778706e0163559cd391ce644ab95c9a48b369ea~~ fix(deps): update engines to v2.26.0-11.c1fcbb503125a193f54f46920f59da1b6c6b859e Jun 22, 2021

renovate bot force-pushed the renovate/engines branch from 3710f88 to 787f43f Compare June 23, 2021 10:57

Jolg42 reviewed Jun 23, 2021

View reviewed changes

Jolg42 assigned williamluke4 and millsp Jun 23, 2021

Jolg42 reviewed Jun 23, 2021

View reviewed changes

janpio reviewed Jun 23, 2021

View reviewed changes

src/packages/sdk/src/__tests__/__snapshots__/engineCommands.test.ts.snap Show resolved Hide resolved

janpio reviewed Jun 23, 2021

View reviewed changes

fix(deps): update engines to v2.26.0-13.a9966aa784861dee7e6b2a9095087…

290688c

…4cbaf7b4984

renovate bot force-pushed the renovate/engines branch from 7ac8445 to 290688c Compare June 23, 2021 13:46

renovate bot changed the title ~~fix(deps): update engines to v2.26.0-11.c1fcbb503125a193f54f46920f59da1b6c6b859e~~ fix(deps): update engines to v2.26.0-13.a9966aa784861dee7e6b2a90950874cbaf7b4984 Jun 23, 2021

update snapshots

9ed4258

Jolg42 approved these changes Jun 23, 2021

View reviewed changes

Jolg42 merged commit 9062fa3 into master Jun 23, 2021

Jolg42 deleted the renovate/engines branch June 23, 2021 14:53

Jolg42 mentioned this pull request Jun 23, 2021

chore(sdk): split up engineCommands tests #7829

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(deps): update engines to v2.26.0-13.a9966aa784861dee7e6b2a90950874cbaf7b4984 #7796

fix(deps): update engines to v2.26.0-13.a9966aa784861dee7e6b2a90950874cbaf7b4984 #7796

renovate bot commented Jun 21, 2021 •

edited

Jolg42 commented Jun 22, 2021

Jolg42 Jun 23, 2021

janpio Jun 23, 2021 •

edited

janpio Jun 23, 2021

Jolg42 Jun 23, 2021

Jolg42 Jun 23, 2021 •

edited

janpio Jun 23, 2021

Jolg42 Jun 23, 2021

williamluke4 Jun 23, 2021

janpio Jun 23, 2021 •

edited

janpio Jun 23, 2021

williamluke4 Jun 23, 2021

williamluke4 Jun 23, 2021

williamluke4 Jun 23, 2021

janpio left a comment

Jolg42 left a comment •

edited

	test('chinook introspected schema', async () => {
	const file = fs.readFileSync(
	path.join(__dirname, '../../fixtures/chinook.prisma'),
	'utf-8',
	)
	const dmmf = await getDMMF({
	datamodel: file,
	})
	const str = JSON.stringify(dmmf)
	expect(str.length).toMatchSnapshot()
	})

	test('chinook introspected schema connectOrCreate', async () => {
	const file = fs.readFileSync(
	path.join(__dirname, '../../fixtures/chinook.prisma'),
	'utf-8',
	)
	const dmmf = await getDMMF({
	datamodel: file,
	})
	const str = JSON.stringify(dmmf)
	expect(str.length).toMatchSnapshot()
	})

fix(deps): update engines to v2.26.0-13.a9966aa784861dee7e6b2a90950874cbaf7b4984 #7796

fix(deps): update engines to v2.26.0-13.a9966aa784861dee7e6b2a90950874cbaf7b4984 #7796

Conversation

renovate bot commented Jun 21, 2021 • edited

Configuration

Jolg42 commented Jun 22, 2021

Choose a reason for hiding this comment

janpio Jun 23, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jolg42 Jun 23, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janpio Jun 23, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janpio left a comment

Choose a reason for hiding this comment

Jolg42 left a comment • edited

Choose a reason for hiding this comment

renovate bot commented Jun 21, 2021 •

edited

janpio Jun 23, 2021 •

edited

Jolg42 Jun 23, 2021 •

edited

janpio Jun 23, 2021 •

edited

Jolg42 left a comment •

edited