chore(prisma): type discovery + fast builds + clean monorepo #8497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @williamluke4 🎉 |
|
I merged my PR before that one and it looks like it created a conflict 🙈 |
# Conflicts: # packages/migrate/package.json
|
I just tried it and so far it works like a charm 💚 |
Jolg42
reviewed
Aug 2, 2021
Comment on lines
+1
to
+31
| import { PrismaClient } from '.' | ||
| import { expectError } from 'tsd' | ||
|
|
||
| // tslint:disable | ||
|
|
||
| const prisma = new PrismaClient({ | ||
| datasources: { | ||
| db: { | ||
| url: 'file:dev.db', | ||
| }, | ||
| }, | ||
| }) | ||
|
|
||
| ;(async () => { | ||
| expectError( | ||
| await prisma.$transaction( | ||
| [prisma.user.findMany(), prisma.$queryRaw`SELECT 1`, 'random string'], | ||
| {}, | ||
| ), | ||
| ) | ||
| expectError(await prisma.$transaction([prisma.$connect()])) | ||
| expectError(await prisma.$transaction([prisma.$disconnect()])) | ||
| expectError( | ||
| await prisma.$transaction([ | ||
| new Promise((res) => res('You Shall Not Pass')), | ||
| ]), | ||
| ) | ||
| expectError(await prisma.$transaction([5])) | ||
| expectError(await prisma.$transaction(['str'])) | ||
| expectError(await prisma.$transaction([{}])) | ||
| })() |
There was a problem hiding this comment.
Looks like an unrelated addition, but nice!
There was a problem hiding this comment.
Thanks! That should be removed
Jolg42
reviewed
Aug 2, 2021
| @@ -24,8 +24,6 @@ Debug.enable = (namespace: string): void => { | |||
|
|
|||
| Debug.enabled = (namespace: string): boolean => DebugNode.enabled(namespace) | |||
|
|
|||
| export declare type Debugger = DebugLib.Debugger | |||
Jolg42
reviewed
Aug 2, 2021
Comment on lines
+11
to
+13
| const { size } = fs.statSync(id) | ||
|
|
||
| console.log('BINARY_SIZE', size) |
There was a problem hiding this comment.
Looks unrelated to types discovery, what is it for?
There was a problem hiding this comment.
Oh yes, that was a debug for tests not passing. Good catch!
Jolg42
reviewed
Aug 2, 2021
Jolg42
added a commit
that referenced
this pull request
Aug 2, 2021
* master: (40 commits) chore(deps): update engines to 2.29.0-5.8062e306decdf2fe2c2dcb8409c513a2023c8653 (#8533) chore(deps): update fkirc/skip-duplicate-actions action to v3.4.1 (#8528) chore: move buildkite folder + fix publish (#8531) chore(prisma): type discovery + fast builds + clean monorepo (#8497) fix(migrate): fix cases where migrate engine was not stopped after an error (#8482) chore: add dash to studio update branch for better branch names (#8507) chore(deps): update dependency @prisma/studio-server to v0.418.0 fix(tar): upgrade to 6.1.2 (#8501) ci: create action for studio updates (#8502) chore(deps): update dependency rollup to v2.55.0 (#8477) chore(deps): update dependency ts-jest to v27.0.4 (#8474) chore(deps): update devdependencies (non-major) chore(deps): update react-prisma chore(deps): update definitelytyped chore: update renovate: ignore engines wrapper pkgs (#8113) docs: remove "(ORM Replacement)" from repo (#8456) fix(deps): update engines to v2.28.0-17.89facabd0366f63911d089156a7a70125bfbcd27 chore(deps): update dependency @prisma/studio-server to v0.417.0 chore(deps): update codecov-action action to v2 [skip ci] (#8352) chore(deps): update engines to 2.28.0-15.d616ac2e761de0623c4f0494620b4199161d9019 (#8412) ...
Jolg42
added a commit
that referenced
this pull request
Aug 2, 2021
* master: (45 commits) chore: pin dependencies (#8534) chore(deps): update engines to 2.29.0-5.8062e306decdf2fe2c2dcb8409c513a2023c8653 (#8533) chore(deps): update fkirc/skip-duplicate-actions action to v3.4.1 (#8528) chore: move buildkite folder + fix publish (#8531) chore(prisma): type discovery + fast builds + clean monorepo (#8497) fix(migrate): fix cases where migrate engine was not stopped after an error (#8482) chore: add dash to studio update branch for better branch names (#8507) chore(deps): update dependency @prisma/studio-server to v0.418.0 fix(tar): upgrade to 6.1.2 (#8501) ci: create action for studio updates (#8502) chore(deps): update dependency rollup to v2.55.0 (#8477) chore(deps): update dependency ts-jest to v27.0.4 (#8474) chore(deps): update devdependencies (non-major) chore(deps): update react-prisma chore(deps): update definitelytyped chore: update renovate: ignore engines wrapper pkgs (#8113) docs: remove "(ORM Replacement)" from repo (#8456) fix(deps): update engines to v2.28.0-17.89facabd0366f63911d089156a7a70125bfbcd27 chore(deps): update dependency @prisma/studio-server to v0.417.0 chore(deps): update codecov-action action to v2 [skip ci] (#8352) ... # Conflicts: # scripts/ci/publish.ts
Jolg42
added a commit
that referenced
this pull request
Aug 2, 2021
* master: (50 commits) chore: pin dependencies (#8534) chore(deps): update engines to 2.29.0-5.8062e306decdf2fe2c2dcb8409c513a2023c8653 (#8533) chore(deps): update fkirc/skip-duplicate-actions action to v3.4.1 (#8528) chore: move buildkite folder + fix publish (#8531) chore(prisma): type discovery + fast builds + clean monorepo (#8497) fix(migrate): fix cases where migrate engine was not stopped after an error (#8482) chore: add dash to studio update branch for better branch names (#8507) chore(deps): update dependency @prisma/studio-server to v0.418.0 fix(tar): upgrade to 6.1.2 (#8501) ci: create action for studio updates (#8502) chore(deps): update dependency rollup to v2.55.0 (#8477) chore(deps): update dependency ts-jest to v27.0.4 (#8474) chore(deps): update devdependencies (non-major) chore(deps): update react-prisma chore(deps): update definitelytyped chore: update renovate: ignore engines wrapper pkgs (#8113) docs: remove "(ORM Replacement)" from repo (#8456) fix(deps): update engines to v2.28.0-17.89facabd0366f63911d089156a7a70125bfbcd27 chore(deps): update dependency @prisma/studio-server to v0.417.0 chore(deps): update codecov-action action to v2 [skip ci] (#8352) ...
Jolg42
added a commit
that referenced
this pull request
Aug 3, 2021
* master: (21 commits) chore(deps): update engines to 2.29.0-7.10fbb58853d626be41afb2930e56e0a36afefb9f (#8538) chore: disable migrate logging feat(migrate): Allow migration engine to log to stdout (#7896) chore: pin dependencies (#8534) chore(deps): update engines to 2.29.0-5.8062e306decdf2fe2c2dcb8409c513a2023c8653 (#8533) chore(deps): update fkirc/skip-duplicate-actions action to v3.4.1 (#8528) chore: move buildkite folder + fix publish (#8531) chore(prisma): type discovery + fast builds + clean monorepo (#8497) fix(migrate): fix cases where migrate engine was not stopped after an error (#8482) chore: add dash to studio update branch for better branch names (#8507) chore(deps): update dependency @prisma/studio-server to v0.418.0 fix(tar): upgrade to 6.1.2 (#8501) ci: create action for studio updates (#8502) chore(deps): update dependency rollup to v2.55.0 (#8477) chore(deps): update dependency ts-jest to v27.0.4 (#8474) chore(deps): update devdependencies (non-major) chore(deps): update react-prisma chore(deps): update definitelytyped chore: update renovate: ignore engines wrapper pkgs (#8113) docs: remove "(ORM Replacement)" from repo (#8456) ...
Jolg42
added a commit
that referenced
this pull request
Aug 3, 2021
* master: fix(db pull): only output schema to stdout when using --print (#8551) chore(deps): update engines to 2.29.0-12.8b139c140bd01ba4dd6c98f44a1edac48baa58e2 (#8552) ci: fix publish ci: debug publish ci: prepare for major bump (#8240) Update update-studio-version.yml fix(migrate): db push after reset if unexecutable step (#8540) chore(deps): update engines to 2.29.0-10.e60a94c3a98104c76460aa8ab556c33fab0e3781 (#8545) chore(deps): update engines to 2.29.0-9.b0d6f0c282944bba506eed792838c02fdbdab0f8 (#8542) chore(deps): update engines to 2.29.0-7.10fbb58853d626be41afb2930e56e0a36afefb9f (#8538) chore: disable migrate logging feat(migrate): Allow migration engine to log to stdout (#7896) chore: pin dependencies (#8534) chore(deps): update engines to 2.29.0-5.8062e306decdf2fe2c2dcb8409c513a2023c8653 (#8533) chore(deps): update fkirc/skip-duplicate-actions action to v3.4.1 (#8528) chore: move buildkite folder + fix publish (#8531) chore(prisma): type discovery + fast builds + clean monorepo (#8497)
Andrew-Colman
pushed a commit
to Andrew-Colman/prisma
that referenced
this pull request
Aug 7, 2021
…8497) Co-authored-by: Joël <joel.galeran@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's all in the title ☝️
closes #8443