run steps on X64 only #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klutchell
reviewed
Mar 25, 2024
klutchell
requested changes
Mar 25, 2024
klutchell
approved these changes
Mar 25, 2024
ab77
added a commit
that referenced
this pull request
Mar 25, 2024
* installing Python dependencies on runner breaks other dependencies (e.g. AWS-CLI) * run steps on Linux/amd64 until actions/setup-python#705 is resolved change-type: patch
|
Dang, but we don't want to hardcode Flowzone jobs to a particular runner, especially if the calling repo is only supposed to only use self-hosted, or the other way around. We can revert this commit and filter by runner architecture when deciding whether or not to setup python and perform the linting. e.g. We can also test the Flowzone PR by pinning the environment-playground repo to a Flowzone branch/tag. |
ab77
added a commit
that referenced
this pull request
Mar 25, 2024
ab77
added a commit
that referenced
this pull request
Mar 25, 2024
* installing Python dependencies on runner breaks other dependencies (e.g. AWS-CLI) * run steps on Linux/amd64 until actions/setup-python#705 is resolved change-type: patch
ab77
added a commit
that referenced
this pull request
Mar 25, 2024
* installing Python dependencies on runner breaks other dependencies (e.g. AWS-CLI) * run steps on Linux/amd64 until actions/setup-python#705 is resolved change-type: patch
This was referenced Mar 26, 2024
ab77
added a commit
that referenced
this pull request
Mar 26, 2024
* installing Python dependencies on runner breaks other dependencies (e.g. AWS-CLI) * run steps on Linux/amd64 until actions/setup-python#705 is resolved change-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change-type: patch