Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getFragment method to ReactLocalization #595
Add getFragment method to ReactLocalization #595
Changes from 14 commits
04bb1a0
cdf5ea9
695874d
435a08b
29be3dd
ab17fdb
a9b73ca
87c73d4
515918e
6027f43
f2b728c
998e786
b950f1c
59671cc
71dfc62
dc130a5
dbfbdb5
8362f23
dcf65c3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure about this. In
<Localized/>
passing each of these in as props makes sense, but here it feels like we're putting different things into the same basket -- esp. as this is so close to the shape of thegetString()
args
argument.My first instinct would be to separate
vars
from the other two, but maybe calling this something other thanargs
could also help?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh heh, good eye. I'd actually argue that renaming
getString
s second argument tovars
would be more appropriate, since the Fluent docs also call them variables, but I can understand that changing the name of an existing API might not be desirable.I could name it something like
props
? Because they're basically analogous to<Localized>
's props, although it could also be confusing, given that they're not React props. Or how aboutparams
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with changing the internal name of the
getSrting()
argument tovars
, because it only impacts the documentation.props
andparams
aren't really better, and both come with their own sets of baggage.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f2b728c