-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add relabel_configs
field to AlertmanagerEndpoints
#6467
Feat: Add relabel_configs
field to AlertmanagerEndpoints
#6467
Conversation
Should I also include proxy url configs in this PR? and maybe also |
no let's tackle one issue at a time. |
// List of alertmanager relabel configs | ||
// | ||
// +optional | ||
RelabelConfigs []*RelabelConfig `json:"relabelConfigs,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RelabelConfigs []*RelabelConfig `json:"relabelConfigs,omitempty"` | |
RelabelConfigs []RelabelConfig `json:"relabelings,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the type after we merge #6479?
I'm not sure if I'm missing something, but are we adding two different relabeling options under alertmanager endpoints? I was almost sure there was only one relabeling option for alertmanagers |
Yes, as of v2.51.0, we have the ability to have relabeling rules for alerts per alertmanager: |
change the signature of ValidateAlertmanagerEndpoints to include pointer to monv1.Prometheus
1214647
to
a769d76
Compare
Thanks! |
Description
We don't support the relabel_configs per AM, along with ProxyConfig, FollowRedirects among other fields. We would like to extend support to these missing fields.
Partially closes: #6461
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
x
in the box that apply.CHANGE
(fix or feature that would cause existing functionality to not work as expected)FEATURE
(non-breaking change which adds functionality)BUGFIX
(non-breaking change which fixes an issue)ENHANCEMENT
(non-breaking change which improves existing functionality)NONE
(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Unit tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.