Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move AlertmanagerEndpoints validation to pkg/prometheus/server #6480

Merged

Conversation

mviswanathsai
Copy link
Contributor

Description

This PR moves the logic for storing AM endpoints to the store and the subsequent validation to pkg/prometheus/server as per comments on #6467.

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • [ x] NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.


@mviswanathsai mviswanathsai requested a review from a team as a code owner April 5, 2024 16:54
@mviswanathsai
Copy link
Contributor Author

I don't understand why the generate and format action is failing.

@yp969803
Copy link
Contributor

yp969803 commented Apr 5, 2024

By looking at the error, the error is

lookup proxy.golang.org: no such host

The CI pipeline not able to resolve the DNS,

@mviswanathsai
Copy link
Contributor Author

Right, I don't know if that has anything to do with the changes though.

@mviswanathsai
Copy link
Contributor Author

@simonpasquier could you look into this?

@slashpai
Copy link
Contributor

slashpai commented Apr 9, 2024

Looks to be sporadic issue, I have re-run the failed job lets see

pkg/prometheus/server/operator.go Outdated Show resolved Hide resolved
pkg/prometheus/server/operator.go Outdated Show resolved Hide resolved
pkg/prometheus/server/operator.go Outdated Show resolved Hide resolved
pkg/prometheus/server/store.go Outdated Show resolved Hide resolved
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we still have merge conflicts to solve here 😬

pkg/prometheus/server/operator.go Outdated Show resolved Hide resolved
@simonpasquier simonpasquier merged commit a1b6218 into prometheus-operator:main May 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants