New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move AlertmanagerEndpoints validation to pkg/prometheus/server #6480
chore: Move AlertmanagerEndpoints validation to pkg/prometheus/server #6480
Conversation
I don't understand why the generate and format action is failing. |
By looking at the error, the error is
The CI pipeline not able to resolve the DNS, |
Right, I don't know if that has anything to do with the changes though. |
@simonpasquier could you look into this? |
Looks to be sporadic issue, I have re-run the failed job lets see |
dd34a45
to
8f03944
Compare
8f03944
to
1153671
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we still have merge conflicts to solve here 😬
1153671
to
f25c394
Compare
f25c394
to
1449438
Compare
1449438
to
3c22e4d
Compare
Description
This PR moves the logic for storing AM endpoints to the store and the subsequent validation to pkg/prometheus/server as per comments on #6467.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
x
in the box that apply.CHANGE
(fix or feature that would cause existing functionality to not work as expected)FEATURE
(non-breaking change which adds functionality)BUGFIX
(non-breaking change which fixes an issue)ENHANCEMENT
(non-breaking change which improves existing functionality)NONE
(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.