Feat: Add relabel_configs field to AlertmanagerEndpoints
#6467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I also include proxy url configs in this PR? and maybe also |
|
no let's tackle one issue at a time. |
| // List of alertmanager relabel configs | ||
| // | ||
| // +optional | ||
| RelabelConfigs []*RelabelConfig `json:"relabelConfigs,omitempty"` |
There was a problem hiding this comment.
Suggested change
| RelabelConfigs []*RelabelConfig `json:"relabelConfigs,omitempty"` | |
| RelabelConfigs []RelabelConfig `json:"relabelings,omitempty"` |
There was a problem hiding this comment.
Can we change the type after we merge #6479?
4 tasks
|
I'm not sure if I'm missing something, but are we adding two different relabeling options under alertmanager endpoints? I was almost sure there was only one relabeling option for alertmanagers |
|
Yes, as of v2.51.0, we have the ability to have relabeling rules for alerts per alertmanager: |
change the signature of ValidateAlertmanagerEndpoints to include pointer to monv1.Prometheus
mviswanathsai
force-pushed
the
alertmanager-missing-fields
branch
from
1214647
to
a769d76
Compare
simonpasquier
approved these changes
May 14, 2024
|
Thanks! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We don't support the relabel_configs per AM, along with ProxyConfig, FollowRedirects among other fields. We would like to extend support to these missing fields.
Partially closes: #6461
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Unit tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.