Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto increment supported Go version #1435

Closed
kakkoyun opened this issue Jan 23, 2024 · 4 comments · Fixed by #1481
Closed

Auto increment supported Go version #1435

kakkoyun opened this issue Jan 23, 2024 · 4 comments · Fixed by #1481

Comments

@kakkoyun
Copy link
Member

kakkoyun commented Jan 23, 2024

Client_golang promises support for the latest the last 3 major versions of Go. On every new Go release, we need to submit a few PRs updating the metrics collected by Go Collector. We already have scripts that autogenerates those new metrics, but it is not fully automated with our CI/CD.


This task is about connecting the dots between CI/CD and Go Collector metrics autogeneration

xref: cncf/mentoring#1120

@dvjsharma
Copy link

Hello @kakkoyun ,

It would be helpful if you could outline the specific segments of the pipeline that haven't been automated yet. Additionally, could you provide detailed insights into the manual tasks required during a new release? If there's any supporting documentation available, please include it.
Thanks!

CC @ArthurSens

@kakkoyun
Copy link
Member Author

kakkoyun commented Feb 6, 2024

Hey @dvjsharmam thanks for the question. All these will be discussed as part of the mentorship program.

IMHO, going through the whole life-cycle of development tasks and helping interns navigate the open-source world is the core idea behind the program. It's not about specifying some issues and just getting them implemented.

I also mentioned what's needed in the issue description. A quick GH search would lend you to the program that generates those metrics https://github.com/prometheus/client_golang/blob/main/prometheus/gen_go_collector_metrics_set.go and an example PR #1105

@dvjsharma
Copy link

Thanks @kakkoyun for the response, excited for the mentorship program! I'll take a look at the resources.

@SachinSahu431
Copy link
Contributor

Relevant PRs:

#1476
#1481
#1489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants