Auto-update Go Collector Metrics for new Go versions #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sachin Sahu <75629410+SachinSahu431@users.noreply.github.com>
Signed-off-by: Sachin Sahu <75629410+SachinSahu431@users.noreply.github.com>
Signed-off-by: Sachin Sahu <75629410+SachinSahu431@users.noreply.github.com>
SachinSahu431
changed the title
ArthurSens
reviewed
Mar 25, 2024
|
Also, you can fix the linting issues of the failed CI by running |
Signed-off-by: Sachin Sahu <75629410+SachinSahu431@users.noreply.github.com>
|
Thank you for the feedback @ArthurSens! I've updated the code and fixed linting issues :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables autogeneration of Go Collector metrics for supported Go versions.
Runnig
make generate-go-collector-test-filescommand will generate the required metrics collected by Go Collector for list of Go versions specified insupported_go_versions.txt.Details about the autogenerated files:
prometheus/gen_go_collector_metrics_set.gowill generatego_collector_metrics_<version>_test.gofile.prometheus/collectors/gen_go_collector_set.gowill generatego_collector_<version>_test.gofile.Subsequent PR will include automatic generation of files when a new Go version is released. Plan is to have a weekly scheduled GitHub action that will check for the release of new Go versions and will open a PR with autogenerated required files.