Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: metrics generation workflow #1481

Merged
merged 9 commits into from Apr 4, 2024
Merged

feat: metrics generation workflow #1481

merged 9 commits into from Apr 4, 2024

Conversation

SachinSahu431
Copy link
Contributor

@SachinSahu431 SachinSahu431 commented Mar 28, 2024 •
edited

This PR adds a bash script that will generate new metric files whenever a new Go version is released. After that, a PR will be raised, containing all these files.

Closes: #1435

@SachinSahu431
Scripts to check new Go version
16e7165 
Signed-off-by: Sachin Sahu <sachinksahu.431@gmail.com>
@SachinSahu431
Changes to test workflow
a9a181b 
Signed-off-by: Sachin Sahu <sachinksahu.431@gmail.com>
ArthurSens
ArthurSens reviewed Mar 28, 2024
View reviewed changes
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried this workflow on a fork?

.github/workflows/update-go-versions.yml Outdated Show resolved Hide resolved
@SachinSahu431
Copy link
Contributor Author

SachinSahu431 commented Mar 28, 2024 •
edited

Update: Yes, the workflow is working as expected! We are getting a PR with autogenerated metric files.

@SachinSahu431
Update workflow to run based on Go release cycle
eea5b78 
Signed-off-by: Sachin Sahu <75629410+SachinSahu431@users.noreply.github.com>
@SachinSahu431
Revert deleted files for testing workflow
a5e2b20 
Signed-off-by: Sachin Sahu <75629410+SachinSahu431@users.noreply.github.com>
@SachinSahu431
Revert deleted file for testing workflow
d08d514 
Signed-off-by: Sachin Sahu <75629410+SachinSahu431@users.noreply.github.com>
@SachinSahu431
Fix linting issue
db9e1c1 
Signed-off-by: Sachin Sahu <75629410+SachinSahu431@users.noreply.github.com>
@SachinSahu431 SachinSahu431 marked this pull request as ready for review April 2, 2024 04:05
@SachinSahu431
Copy link
Contributor Author

Hey!

Here is one example of autogenerated PR for Go version 1.22: SachinSahu431#2

Please let me know if we should modify the format of PR. For example: adding some labels, marking it draft by default, etc.

@SachinSahu431
Copy link
Contributor Author

Note that in supported_go_versions.txt, older Go versions are not being removed. Out of all versions listed in this txt file, only the top 3 versions are being used by update-go-version.bash file even if 4th (and later) versions are supported.

@SachinSahu431 SachinSahu431 mentioned this pull request Apr 2, 2024
Merged
kakkoyun
kakkoyun reviewed Apr 2, 2024
View reviewed changes
update-go-version.bash Outdated Show resolved Hide resolved
.github/workflows/update-go-versions.yml Outdated Show resolved Hide resolved
@SachinSahu431
Update cron schedule to per month
1a54900 
Signed-off-by: Sachin Sahu <75629410+SachinSahu431@users.noreply.github.com>
@SachinSahu431
Update bash file
74a9e0b 
Signed-off-by: Sachin Sahu <75629410+SachinSahu431@users.noreply.github.com>
@ArthurSens
Copy link
Member

Note that in supported_go_versions.txt, older Go versions are not being removed. Out of all versions listed in this txt file, only the top 3 versions are being used by update-go-version.bash file even if 4th (and later) versions are supported.

I think this will cause confusion in the future 😬. Could we make sure that we only have the supported versions in the supported_go_versions file? I.e. the 3 latest go versions

@SachinSahu431
Keep latest 3 Go versions in supported_go_versions
4fec0a5 
Signed-off-by: Sachin Sahu <75629410+SachinSahu431@users.noreply.github.com>
@SachinSahu431
Copy link
Contributor Author

@ArthurSens made the changes, thanks! 🙌

@SachinSahu431 SachinSahu431 mentioned this pull request Apr 4, 2024
Closed
@kakkoyun kakkoyun merged commit 76fa980 into prometheus:main Apr 4, 2024
9 checks passed
@SachinSahu431 SachinSahu431 deleted the metrics-generation-workflow branch April 12, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

@ArthurSens ArthurSens Awaiting requested review from ArthurSens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto increment supported Go version
3 participants
@SachinSahu431 @ArthurSens @kakkoyun