Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data-race in metric without code and method but with WithLabelFromCtx #1318

Merged
merged 1 commit into from Aug 1, 2023
Merged

Fix data-race in metric without code and method but with WithLabelFromCtx #1318

merged 1 commit into from Aug 1, 2023

Conversation

tigrato
Copy link
Contributor

@tigrato tigrato commented Jul 30, 2023

This PR fixes a data race that exists when the metric used in any promhttp middleware doesn't collect the code and method but uses WithLabelFromCtx to collect values from context.

The problem happens because when no code and method tags are collected, the labels function returns a pre-initialized map emptyLabels for every request.

When one or multiple WithLabelFromCtx options are configured, the returned map from the labels function call is used to collect the metrics from context which creates a multi-write data race.

Fixes #1317

@tigrato
Copy link
Contributor Author

tigrato commented Jul 30, 2023

Bartłomiej Płotka @bwplotka
Kemal Akkoyun @kakkoyun

Do you mind taking a look?

bwplotka
bwplotka reviewed Jul 31, 2023
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can we add regression test? This will make sure we don't reintroduce same bug.

Current logic with emptyLabels that at some point are not empty is also weird, let's fix it.

prometheus/promhttp/instrument_server.go Outdated
Comment on lines 403 to 406
if hasExtraLabelsCtx {
return prometheus.Labels{}
}
return emptyLabels
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels wrong. If the emptyLabels are no longer empty, this is highly misleading. We should fix the code and not rely on that global var or make sure no one writes to it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bwplotka

I removed the usage of the global emptyLabels map because as you say it's highly misleading and it makes it trivial to introduce new data races by writing into the output of the labels func.

@tigrato
Fix data-race in metric without code and method but with `WithLabelFr…
5113fb6 
…omCtx`

This commit fixes a data race that exists when the metric used in any
`promhttp` middleware doesn't collect the `code` and `method` but uses
`WithLabelFromCtx` to collect values from context.

The problem happens because when no `code` and `method` tags are
collected, the `labels` function returns a pre-initialized map
`emptyLabels` for every request.

When one or multipe `WithLabelFromCtx` options are configured, the
returned map from the `labels` function call is used to collect the
metrics from context which creates a multi-write data race.

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
@tigrato tigrato requested a review from bwplotka July 31, 2023 10:03
bwplotka
bwplotka approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was simple fix =D

@bwplotka bwplotka merged commit 59c00e3 into prometheus:main Aug 1, 2023
7 checks passed
renovate bot added a commit to open-feature/flagd that referenced this pull request Sep 27, 2023
@renovate
fix(deps): update module github.com/prometheus/client_golang to v1.17…
9065cba 
….0 (#939)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang)
| require | minor | `v1.16.0` -> `v1.17.0` |

---

### Release Notes

<details>
<summary>prometheus/client_golang
(github.com/prometheus/client_golang)</summary>

###
[`v1.17.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.17.0)

[Compare
Source](https://togithub.com/prometheus/client_golang/compare/v1.16.0...v1.17.0)

#### What's Changed

- \[CHANGE] Minimum required go version is now 1.19 (we also test
client_golang against new 1.21 version).
[#&#8203;1325](https://togithub.com/prometheus/client_golang/issues/1325)
- \[FEATURE] Add support for Created Timestamps in Counters, Summaries
and Historams.
[#&#8203;1313](https://togithub.com/prometheus/client_golang/issues/1313)
- \[ENHANCEMENT] Enable detection of a native histogram without
observations.
[#&#8203;1314](https://togithub.com/prometheus/client_golang/issues/1314)

<details><summary>Commits</summary>

- Merge v1.16.0 to main by
[@&#8203;bwplotka](https://togithub.com/bwplotka) in
[prometheus/client_golang#1293
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[prometheus/client_golang#1297
- ci: define minimal permissions to GitHub workflows by
[@&#8203;diogoteles08](https://togithub.com/diogoteles08) in
[prometheus/client_golang#1295
- Do not allocate memory when there's no constraints by
[@&#8203;Okhoshi](https://togithub.com/Okhoshi) in
[prometheus/client_golang#1296
- Bump golang.org/x/sys from 0.8.0 to 0.9.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1306
- Bump google.golang.org/grpc from 1.45.0 to 1.53.0 in /tutorial/whatsup
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1307
- histogram: Enable detection of a native histogram without observations
by [@&#8203;beorn7](https://togithub.com/beorn7) in
[prometheus/client_golang#1314
- Bump github.com/prometheus/procfs from 0.10.1 to 0.11.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1305
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[prometheus/client_golang#1302
- Fix data-race in metric without `code` and `method` but with
`WithLabelFromCtx` by [@&#8203;tigrato](https://togithub.com/tigrato) in
[prometheus/client_golang#1318
- Add missing tick "\`" in README by
[@&#8203;ZiViZiViZ](https://togithub.com/ZiViZiViZ) in
[prometheus/client_golang#1321
- Bump golang.org/x/sys from 0.9.0 to 0.10.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1320
- Bump github.com/prometheus/procfs from 0.11.0 to 0.11.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1319
- docs: trivial grammar fixes to improve readability in promauto Godoc
by [@&#8203;sengi](https://togithub.com/sengi) in
[prometheus/client_golang#1322
- Add Go 1.21 support by
[@&#8203;kakkoyun](https://togithub.com/kakkoyun) in
[prometheus/client_golang#1325
- Bump client_model by
[@&#8203;ArthurSens](https://togithub.com/ArthurSens) in
[prometheus/client_golang#1323
- histogram docs: Fixed minor nit. by
[@&#8203;bwplotka](https://togithub.com/bwplotka) in
[prometheus/client_golang#1324
- Update building by [@&#8203;SuperQ](https://togithub.com/SuperQ) in
[prometheus/client_golang#1326
- Bump golang.org/x/sys from 0.10.0 to 0.11.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1331
- Bump github.com/prometheus/client_golang from
1.15.1-0.20230416215738-0963f595c689 to 1.16.0 in /tutorial/whatsup by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1329
- Bump github.com/prometheus/client_golang from 1.13.1 to 1.16.0 in
/examples/middleware by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1328
- Bump github.com/prometheus/common from 0.42.0 to 0.44.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1284
- Bump github.com/prometheus/common from 0.42.0 to 0.44.0 in
/tutorial/whatsup by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1330
- Bump google.golang.org/protobuf from 1.30.0 to 1.31.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1304
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[prometheus/client_golang#1332
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[prometheus/client_golang#1338
- Cleanup golangci-lint errcheck by
[@&#8203;SuperQ](https://togithub.com/SuperQ) in
[prometheus/client_golang#1339
- Add go_godebug_non_default_behavior_tlsmaxrsasize_events_total by
[@&#8203;alexandear](https://togithub.com/alexandear) in
[prometheus/client_golang#1348
- Extend Counters, Summaries and Histograms with creation timestamp by
[@&#8203;ArthurSens](https://togithub.com/ArthurSens) in
[prometheus/client_golang#1313
- Fix typos in comments, tests, and errors by
[@&#8203;alexandear](https://togithub.com/alexandear) in
[prometheus/client_golang#1346
- Deprecated comment should begin with "Deprecated:" by
[@&#8203;alexandear](https://togithub.com/alexandear) in
[prometheus/client_golang#1347
- Add changelog entry for 1.17 by
[@&#8203;ArthurSens](https://togithub.com/ArthurSens) in
[prometheus/client_golang#1352

</details>

#### New Contributors
* @&#8203;diogoteles08 made their first
contributi[prometheus/client_golang#1295
* @&#8203;tigrato made their first
contributi[prometheus/client_golang#1318
* @&#8203;ZiViZiViZ made their first
contributi[prometheus/client_golang#1321
* @&#8203;sengi made their first
contributi[prometheus/client_golang#1322
* @&#8203;ArthurSens made their first
contributi[prometheus/client_golang#1323
* @&#8203;alexandear made their first
contributi[prometheus/client_golang#1348

**Full Changelog**:
prometheus/client_golang@v1.16.0...v1.17.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-feature/flagd).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDcuMiIsInVwZGF0ZWRJblZlciI6IjM2LjEwNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
apricote pushed a commit to hetznercloud/hcloud-cloud-controller-manager that referenced this pull request Sep 28, 2023
@renovate
deps: update module github.com/prometheus/client_golang to v1.17.0 (#522
51b83ec 
)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang)
| require | minor | `v1.16.0` -> `v1.17.0` |

---

### Release Notes

<details>
<summary>prometheus/client_golang
(github.com/prometheus/client_golang)</summary>

###
[`v1.17.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.17.0)

[Compare
Source](https://togithub.com/prometheus/client_golang/compare/v1.16.0...v1.17.0)

#### What's Changed

- \[CHANGE] Minimum required go version is now 1.19 (we also test
client_golang against new 1.21 version).
[#&#8203;1325](https://togithub.com/prometheus/client_golang/issues/1325)
- \[FEATURE] Add support for Created Timestamps in Counters, Summaries
and Historams.
[#&#8203;1313](https://togithub.com/prometheus/client_golang/issues/1313)
- \[ENHANCEMENT] Enable detection of a native histogram without
observations.
[#&#8203;1314](https://togithub.com/prometheus/client_golang/issues/1314)

<details><summary>Commits</summary>

- Merge v1.16.0 to main by
[@&#8203;bwplotka](https://togithub.com/bwplotka) in
[prometheus/client_golang#1293
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[prometheus/client_golang#1297
- ci: define minimal permissions to GitHub workflows by
[@&#8203;diogoteles08](https://togithub.com/diogoteles08) in
[prometheus/client_golang#1295
- Do not allocate memory when there's no constraints by
[@&#8203;Okhoshi](https://togithub.com/Okhoshi) in
[prometheus/client_golang#1296
- Bump golang.org/x/sys from 0.8.0 to 0.9.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1306
- Bump google.golang.org/grpc from 1.45.0 to 1.53.0 in /tutorial/whatsup
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1307
- histogram: Enable detection of a native histogram without observations
by [@&#8203;beorn7](https://togithub.com/beorn7) in
[prometheus/client_golang#1314
- Bump github.com/prometheus/procfs from 0.10.1 to 0.11.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1305
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[prometheus/client_golang#1302
- Fix data-race in metric without `code` and `method` but with
`WithLabelFromCtx` by [@&#8203;tigrato](https://togithub.com/tigrato) in
[prometheus/client_golang#1318
- Add missing tick "\`" in README by
[@&#8203;ZiViZiViZ](https://togithub.com/ZiViZiViZ) in
[prometheus/client_golang#1321
- Bump golang.org/x/sys from 0.9.0 to 0.10.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1320
- Bump github.com/prometheus/procfs from 0.11.0 to 0.11.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1319
- docs: trivial grammar fixes to improve readability in promauto Godoc
by [@&#8203;sengi](https://togithub.com/sengi) in
[prometheus/client_golang#1322
- Add Go 1.21 support by
[@&#8203;kakkoyun](https://togithub.com/kakkoyun) in
[prometheus/client_golang#1325
- Bump client_model by
[@&#8203;ArthurSens](https://togithub.com/ArthurSens) in
[prometheus/client_golang#1323
- histogram docs: Fixed minor nit. by
[@&#8203;bwplotka](https://togithub.com/bwplotka) in
[prometheus/client_golang#1324
- Update building by [@&#8203;SuperQ](https://togithub.com/SuperQ) in
[prometheus/client_golang#1326
- Bump golang.org/x/sys from 0.10.0 to 0.11.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1331
- Bump github.com/prometheus/client_golang from
1.15.1-0.20230416215738-0963f595c689 to 1.16.0 in /tutorial/whatsup by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1329
- Bump github.com/prometheus/client_golang from 1.13.1 to 1.16.0 in
/examples/middleware by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1328
- Bump github.com/prometheus/common from 0.42.0 to 0.44.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1284
- Bump github.com/prometheus/common from 0.42.0 to 0.44.0 in
/tutorial/whatsup by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1330
- Bump google.golang.org/protobuf from 1.30.0 to 1.31.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1304
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[prometheus/client_golang#1332
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[prometheus/client_golang#1338
- Cleanup golangci-lint errcheck by
[@&#8203;SuperQ](https://togithub.com/SuperQ) in
[prometheus/client_golang#1339
- Add go_godebug_non_default_behavior_tlsmaxrsasize_events_total by
[@&#8203;alexandear](https://togithub.com/alexandear) in
[prometheus/client_golang#1348
- Extend Counters, Summaries and Histograms with creation timestamp by
[@&#8203;ArthurSens](https://togithub.com/ArthurSens) in
[prometheus/client_golang#1313
- Fix typos in comments, tests, and errors by
[@&#8203;alexandear](https://togithub.com/alexandear) in
[prometheus/client_golang#1346
- Deprecated comment should begin with "Deprecated:" by
[@&#8203;alexandear](https://togithub.com/alexandear) in
[prometheus/client_golang#1347
- Add changelog entry for 1.17 by
[@&#8203;ArthurSens](https://togithub.com/ArthurSens) in
[prometheus/client_golang#1352

</details>

#### New Contributors
* @&#8203;diogoteles08 made their first
contributi[prometheus/client_golang#1295
* @&#8203;tigrato made their first
contributi[prometheus/client_golang#1318
* @&#8203;ZiViZiViZ made their first
contributi[prometheus/client_golang#1321
* @&#8203;sengi made their first
contributi[prometheus/client_golang#1322
* @&#8203;ArthurSens made their first
contributi[prometheus/client_golang#1323
* @&#8203;alexandear made their first
contributi[prometheus/client_golang#1348

**Full Changelog**:
prometheus/client_golang@v1.16.0...v1.17.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/hetznercloud/hcloud-cloud-controller-manager).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDcuMiIsInVwZGF0ZWRJblZlciI6IjM2LjEwNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
nono added a commit to cozy/cozy-stack that referenced this pull request Oct 2, 2023
@nono
fix(deps): update module github.com/prometheus/client_golang to v1.17…
b5aa181 
….0 (#4144)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang)
| require | minor | `v1.16.0` -> `v1.17.0` |

---

### Release Notes

<details>
<summary>prometheus/client_golang
(github.com/prometheus/client_golang)</summary>

###
[`v1.17.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.17.0)

[Compare
Source](https://togithub.com/prometheus/client_golang/compare/v1.16.0...v1.17.0)

#### What's Changed

- \[CHANGE] Minimum required go version is now 1.19 (we also test
client_golang against new 1.21 version).
[#&#8203;1325](https://togithub.com/prometheus/client_golang/issues/1325)
- \[FEATURE] Add support for Created Timestamps in Counters, Summaries
and Historams.
[#&#8203;1313](https://togithub.com/prometheus/client_golang/issues/1313)
- \[ENHANCEMENT] Enable detection of a native histogram without
observations.
[#&#8203;1314](https://togithub.com/prometheus/client_golang/issues/1314)

<details><summary>Commits</summary>

- Merge v1.16.0 to main by
[@&#8203;bwplotka](https://togithub.com/bwplotka) in
[prometheus/client_golang#1293
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[prometheus/client_golang#1297
- ci: define minimal permissions to GitHub workflows by
[@&#8203;diogoteles08](https://togithub.com/diogoteles08) in
[prometheus/client_golang#1295
- Do not allocate memory when there's no constraints by
[@&#8203;Okhoshi](https://togithub.com/Okhoshi) in
[prometheus/client_golang#1296
- Bump golang.org/x/sys from 0.8.0 to 0.9.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1306
- Bump google.golang.org/grpc from 1.45.0 to 1.53.0 in /tutorial/whatsup
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1307
- histogram: Enable detection of a native histogram without observations
by [@&#8203;beorn7](https://togithub.com/beorn7) in
[prometheus/client_golang#1314
- Bump github.com/prometheus/procfs from 0.10.1 to 0.11.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1305
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[prometheus/client_golang#1302
- Fix data-race in metric without `code` and `method` but with
`WithLabelFromCtx` by [@&#8203;tigrato](https://togithub.com/tigrato) in
[prometheus/client_golang#1318
- Add missing tick "\`" in README by
[@&#8203;ZiViZiViZ](https://togithub.com/ZiViZiViZ) in
[prometheus/client_golang#1321
- Bump golang.org/x/sys from 0.9.0 to 0.10.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1320
- Bump github.com/prometheus/procfs from 0.11.0 to 0.11.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1319
- docs: trivial grammar fixes to improve readability in promauto Godoc
by [@&#8203;sengi](https://togithub.com/sengi) in
[prometheus/client_golang#1322
- Add Go 1.21 support by
[@&#8203;kakkoyun](https://togithub.com/kakkoyun) in
[prometheus/client_golang#1325
- Bump client_model by
[@&#8203;ArthurSens](https://togithub.com/ArthurSens) in
[prometheus/client_golang#1323
- histogram docs: Fixed minor nit. by
[@&#8203;bwplotka](https://togithub.com/bwplotka) in
[prometheus/client_golang#1324
- Update building by [@&#8203;SuperQ](https://togithub.com/SuperQ) in
[prometheus/client_golang#1326
- Bump golang.org/x/sys from 0.10.0 to 0.11.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1331
- Bump github.com/prometheus/client_golang from
1.15.1-0.20230416215738-0963f595c689 to 1.16.0 in /tutorial/whatsup by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1329
- Bump github.com/prometheus/client_golang from 1.13.1 to 1.16.0 in
/examples/middleware by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1328
- Bump github.com/prometheus/common from 0.42.0 to 0.44.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1284
- Bump github.com/prometheus/common from 0.42.0 to 0.44.0 in
/tutorial/whatsup by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1330
- Bump google.golang.org/protobuf from 1.30.0 to 1.31.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[prometheus/client_golang#1304
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[prometheus/client_golang#1332
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[prometheus/client_golang#1338
- Cleanup golangci-lint errcheck by
[@&#8203;SuperQ](https://togithub.com/SuperQ) in
[prometheus/client_golang#1339
- Add go_godebug_non_default_behavior_tlsmaxrsasize_events_total by
[@&#8203;alexandear](https://togithub.com/alexandear) in
[prometheus/client_golang#1348
- Extend Counters, Summaries and Histograms with creation timestamp by
[@&#8203;ArthurSens](https://togithub.com/ArthurSens) in
[prometheus/client_golang#1313
- Fix typos in comments, tests, and errors by
[@&#8203;alexandear](https://togithub.com/alexandear) in
[prometheus/client_golang#1346
- Deprecated comment should begin with "Deprecated:" by
[@&#8203;alexandear](https://togithub.com/alexandear) in
[prometheus/client_golang#1347
- Add changelog entry for 1.17 by
[@&#8203;ArthurSens](https://togithub.com/ArthurSens) in
[prometheus/client_golang#1352

</details>

#### New Contributors
* @&#8203;diogoteles08 made their first
contributi[prometheus/client_golang#1295
* @&#8203;tigrato made their first
contributi[prometheus/client_golang#1318
* @&#8203;ZiViZiViZ made their first
contributi[prometheus/client_golang#1321
* @&#8203;sengi made their first
contributi[prometheus/client_golang#1322
* @&#8203;ArthurSens made their first
contributi[prometheus/client_golang#1323
* @&#8203;alexandear made their first
contributi[prometheus/client_golang#1348

**Full Changelog**:
prometheus/client_golang@v1.16.0...v1.17.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 6am on Monday" in timezone
Europe/Paris, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cozy/cozy-stack).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data race when using promhttp handlers without methodor code but with WithLabelFromCtx
2 participants
@tigrato @bwplotka