Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove hardcoded supported Go versions from go.yml #1489

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

SachinSahu431
Copy link
Contributor

Currently, go.yml file contains hardcoded list of supported Go versions. This needs to be manually updated when a new Go version is available.

With this PR, this list will be fetched from supprted_go_versions.txt (only the latest 3 Go versions).

Related PR: #1481

Signed-off-by: Sachin Sahu <75629410+SachinSahu431@users.noreply.github.com>
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I just have one suggestion about the supported_go_versions file.

I'd remove the logic that selects only the 3 first lines, and one a separate PR we can make sure there's only 3 supported versions on that file

.github/workflows/go.yml Outdated Show resolved Hide resolved
Signed-off-by: Sachin Sahu <75629410+SachinSahu431@users.noreply.github.com>
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job :)

@ArthurSens ArthurSens merged commit e3bea8a into prometheus:main Apr 2, 2024
9 checks passed
@SachinSahu431 SachinSahu431 deleted the update-go-yml branch April 2, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants