[bazel] Move Java runtime/toolchains into //java #7190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @ittaiz |
|
Nice! Do you think the same can be done for python? |
Yannic
force-pushed
the
bazel_java
branch
3 times, most recently
from
112ee78
to
64c3d43
Compare
|
I haven't looked into doing the same for other languages yet. Will do when this lands. |
|
Thanks! |
|
@rafi-kamal Thanks! Looks like there were infra issues yesterday. Maybe re-run the tests? |
This change moves `java_library` targets from the top-level BUILD file
into `//java/{core,lite,util}` and declares `alias` targets to point to
their new locations (hence, this is not a breaking change).
This will allow users that don't use Java to stop depending on
`@rules_java` (e.g. as requested in
bazelbuild/rules_scala#989 (comment)).
Note that there is no intention to deprecate + remove the top-level
targets in the foreseeable future.
|
@Yannic can you please add the build files to java_EXTRA_DIST in https://github.com/protocolbuffers/protobuf/blob/master/Makefile.am? The PHP and Python failures are unrelated. |
|
@rafi-kamal Thanks, done! |
Yannic
added a commit
to Yannic/continuous-integration
that referenced
this pull request
Feb 21, 2020
Java-specific targets were moved into //java in protocolbuffers/protobuf#7190
fweikert
pushed a commit
to bazelbuild/continuous-integration
that referenced
this pull request
Feb 21, 2020
Java-specific targets were moved into //java in protocolbuffers/protobuf#7190
Yannic
added a commit
to Yannic/protobuf
that referenced
this pull request
Jul 8, 2020
Removing language-specific targets from the top-level BUILD file will allow users to keep their workspaces smaller and easier to maintain by not depending on language rules they don't need. Similar work was done for Java in protocolbuffers#7190.
acozzette
pushed a commit
that referenced
this pull request
Jul 20, 2020
Removing language-specific targets from the top-level BUILD file will allow users to keep their workspaces smaller and easier to maintain by not depending on language rules they don't need. Similar work was done for Java in #7190.
vesavlad
pushed a commit
to vesavlad/protobuf
that referenced
this pull request
Sep 22, 2020
Removing language-specific targets from the top-level BUILD file will allow users to keep their workspaces smaller and easier to maintain by not depending on language rules they don't need. Similar work was done for Java in protocolbuffers#7190.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves
java_librarytargets from the top-level BUILD fileinto
//java/{core,lite,util}and declaresaliastargets to point totheir new locations (hence, this is not a breaking change).
This will allow users that don't use Java to stop depending on
@rules_java(e.g. as requested inbazelbuild/rules_scala#989 (comment)).
Note that there is no intention to deprecate + remove the top-level
targets in the foreseeable future.