Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.1 compability #9364

Closed
spickermann opened this issue Jan 3, 2022 · 7 comments · Fixed by #9566
Closed

Add Ruby 3.1 compability #9364

spickermann opened this issue Jan 3, 2022 · 7 comments · Fixed by #9566
Assignees
Labels

Comments

@spickermann
Copy link

Ruby 3.1.0 was released on Christmas.

Today I started updating our apps and noticed that google-protobuf is not compatible with Ruby 3.1 yet.

google-protobuf-3.19.1-x86_64-darwin requires ruby version < 3.1.dev, >= 2.3, which is incompatible with 
the current version, ruby 3.1.0p0

I understand that it might take some time to get this fixes – especially during the end of year break. I created this issue to keep track of this and me notified when a updated version was released.

Cheers and Happy New Year.

@brauliobo
Copy link

same here, what is holding this?

@perezd
Copy link
Contributor

perezd commented Feb 25, 2022

Has anyone tried upgrading this to see what the breakages are? We're accepting PRs.

@arathunku
Copy link

We've been running an updated version in ~medium size app for the last few weeks, no new errors.

@perezd
Copy link
Contributor

perezd commented Feb 25, 2022

@arathunku, would you be comfortable sending a PR to allow Ruby 3.1 to be acceptable? We're not immediately sure where this limitation is coming from.

@jchestershopify
Copy link

As another data point, we are seeing this problem across multiple apps, affecting google-protobuf up to and including v3.19.4.

@haberman
Copy link
Member

haberman commented Mar 1, 2022

It's unclear to me why our gem is not compatible with Ruby 3.1.

Our gemspec's required_ruby_version is >=2.3:

s.required_ruby_version = '>= 2.3'

There is nothing from our end that should be prohibiting 3.1.

@Maaarcocr
Copy link
Contributor

It's unclear to me why our gem is not compatible with Ruby 3.1.

Our gemspec's required_ruby_version is >=2.3:

s.required_ruby_version = '>= 2.3'

There is nothing from our end that should be prohibiting 3.1.

The issue is that the pre-compiled versions of the gem do not support 3.1 as per

IN_DOCKER=true rake native:#{plat} pkg/#{spec.full_name}-#{plat}.gem RUBY_CC_VERSION=3.0.0:2.7.0:2.6.0:2.5.0

I made a PR to fix it here: #9566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants