New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add class method Timestamp.from_time to ruby well known types #8562
Add class method Timestamp.from_time to ruby well known types #8562
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@mcclymont, could you sign the cla? |
@googlebot I signed it! |
@TeBoring What's the next step? I don't understand the CI failures |
Sorry for the delay, I'm rerunning tests now and will let you know if there's anything that needs fixed. |
Thanks for the addition, merging now! |
I was surprised to find out that
from_time
was not a class method, but an instance method.This limits its usefulness, as to create a new Timestamp you have to first instantiate the object, then call the from_time method, and then you need to return/use the saved instance, because the from_time method returns the self.nanos value, rather than the timestamp itself.
Code example
Before
After