Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add class method Timestamp.from_time to ruby well known types #8562

Merged
merged 1 commit into from Oct 14, 2021
Merged

Add class method Timestamp.from_time to ruby well known types #8562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions ruby/lib/google/protobuf/well_known_types.rb
View file
Open in desktop
Expand Up @@ -85,6 +85,11 @@ def to_time
def from_time(time)
self.seconds = time.to_i
self.nanos = time.nsec
self
end

def self.from_time(time)
new.from_time(time)
end

def to_i
Expand Down
8 changes: 6 additions & 2 deletions ruby/tests/well_known_types_test.rb
View file
Open in desktop
Expand Up @@ -15,16 +15,20 @@ def test_timestamp

# millisecond accuracy
time = Time.at(123456, 654321)
ts.from_time(time)
ts = Google::Protobuf::Timestamp.from_time(time)
assert_equal 123456, ts.seconds
assert_equal 654321000, ts.nanos
assert_equal time, ts.to_time

# nanosecond accuracy
time = Time.at(123456, Rational(654321321, 1000))
ts.from_time(time)
ts = Google::Protobuf::Timestamp.from_time(time)
assert_equal 654321321, ts.nanos
assert_equal time, ts.to_time

# Instance method returns the same value as class method
assert_equal Google::Protobuf::Timestamp.new.from_time(time),
Google::Protobuf::Timestamp.from_time(time)
end

def test_duration
Expand Down