Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[csharp] ByteString.CreateCodedInput should use ArraySegment offset and count #8740

Merged
merged 1 commit into from Jun 18, 2021
Merged

[csharp] ByteString.CreateCodedInput should use ArraySegment offset and count #8740

merged 1 commit into from Jun 18, 2021

Commits on Jun 17, 2021

  1. [csharp] ByteString.CreateCodedInput should use ArraySegment offset a… 

    …nd count

CreateCodedInput is created from the underlying array behind the ByteString.
If this was created from a larger array (via Memory<byte> or ArrayPool etc)
then the CodedInput refers to the wrong section of memory.

Change is to add the offset and count like the other methods that use the
ArraySegment (ToString, ToBase64, WriteTo).
    @kiwidev
    kiwidev committed Jun 17, 2021
    Copy the full SHA
    9848fe2 View commit details
    Browse the repository at this point in the history