Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update our build script to publish Mac aarch_64 binaries #9203

Merged
merged 1 commit into from Nov 8, 2021

Conversation

acozzette
Copy link
Member

@acozzette acozzette commented Nov 8, 2021

These are still x86-64 binaries at the moment (see #8557), but should be
usable on M1 Macs in the Rosetta compatibility mode. Let's start
publishing them on our GitHub release page and then eventually we can
make them into true aarch_64 binaries.

This fixes #9200.

These are still x86-64 binaries at the moment (see protocolbuffers#8557), but should be
usable on M1 Macs in the Rosetta compatibility mode. Let's start
publishing them on our GitHub release page and then eventually we can
make them into true aarch_64 binaries.

This fixes protocolbuffers#9200.
Copy link
Contributor

@perezd perezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@acozzette acozzette merged commit 13d559b into protocolbuffers:master Nov 8, 2021
@acozzette acozzette deleted the mac-m1 branch November 8, 2021 21:40
@kdubb
Copy link

kdubb commented Nov 9, 2021

@acozzette Will this ensure they make them into Maven Central for Java builds?

For the Java artifact io.grpc:protoc-gen-grpc-java:osx-aarch_64:exe. Currently I just copy the x85_64 artifact to aarch_64, so I'm sure this method works.

Apparently there's another com.google.protobuf:protoc:osx-aarch_64 but the Maven never seems to request it.

FYI, this is when I'm trying to build Quarkus.

@acozzette
Copy link
Member Author

The aarch64 binary has already been on Maven Central since at least 3.17.3: https://repo1.maven.org/maven2/com/google/protobuf/protoc/3.17.3

@kdubb
Copy link

kdubb commented Nov 9, 2021

Ahh... that's why the build doesn't complain about thecom.google.protobuf:protoc:osx-aarch_64 artifact after I update to 3.19.

What about https://repo1.maven.org/maven2/io/grpc/protoc-gen-grpc-java/1.42.0? It still has no aarch64 binary.

@kdubb
Copy link

kdubb commented Nov 9, 2021

I guess that's a different project. Sorry.

@acozzette
Copy link
Member Author

No problem, gRPC is a different project but still somewhat closely related to protobuf. You could try asking the gRPC team if they could add an aarch_64 binary.

cbeams added a commit to cbeams/bisq that referenced this pull request Nov 12, 2021
Includes upgrading protobuf and grpc-java to compatible versions
 - protocolbuffers/protobuf#9203
 - grpc/grpc-java#8691

Upgraded to javafx 17.0.1

Still requires having a local javafx (17.0.1) sdk for reasons I don't
fully understand. This is to avoid the "No toolkit found" error. Get
this SDK from https://gluonhq.com/products/javafx/#ea.o

At this point, ./gradlew :desktop:run brings up the GUI but blows up on
what appears to be this still unfixed error:

 - sshahine/JFoenix#1187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release binaries for darwin arm64 (M1 Macs) are missing from GitHub release
4 participants