[Ruby] Include "descriptor_pb.rb" well-known protobuf rb in repository #9219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is normally built by the "genproto" task thats triggered as part of "rake build", but an installation through bundler where this gem is sourced through the "git" source option won't call the Rakefile at all, causing a LoadError for google/protobuf/descriptor_pb.
acozzette
requested changes
Feb 11, 2022
There was a problem hiding this comment.
Thanks for the pull request! This looks good but I think we would need two additional changes before we can accept this:
- Add the new file to
ruby_EXTRA_DISTaround here. This will fix the failing distcheck tests. - Update
generate_descriptor_proto.shto keepdescriptor_pb.rbup to date. That script is responsible for updating other checked-in generated code files like this one.
|
@lfittl I'm going to go ahead and close this since it's been a few weeks with no activity, but feel free to comment here if you would like to reopen this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #8850 there is a hard requirement for
descriptor_pb.rbto exist in order for the gem to load. Unfortunately that file only gets created when runningrake build.An installation through bundler where this gem is sourced through the "git" source option won't call the Rakefile at all, causing a LoadError for google/protobuf/descriptor_pb. See also someone running into this problem when testing a different PR: #8420 (comment)
This change fixes this by including the
descriptor_pb.rbfile directly in the repository. It also adds the other well-knownlib/google/*_pb.rbfiles to the.gitignorelist to make it explicit these are not intended to be committed. Afterwards this gem can again be included via a git source, like this: