Compatibility with Annotations 2 #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirdan
approved these changes
Dec 20, 2022
|
The PHP-CS-Fixer failure looks unrelated. But I might need some help getting the high-deps builds green. |
I think the only option currently is to suppress / baseline the |
seferov
pushed a commit
that referenced
this pull request
Dec 23, 2022
* Compatibility with Annotations 2 * Suppress UnusedPsalmSuppress Co-authored-by: Bruce Weirdan <weirdan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running this plugin having Doctrine Annotations 2 installed currently results in a crash: https://github.com/doctrine/DoctrineBundle/actions/runs/3742592139/jobs/6353730157
The call to
AnnotationRegistry::registerLoader()is safeguarded with amethod_exists()call now. Alternatively, we could also declare a conflict with Annotations < 1.10 and remove the call entirely.