fix: slice bounds out of range on select printer #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
==========================================
+ Coverage 81.10% 81.53% +0.42%
==========================================
Files 29 29
Lines 2101 2101
==========================================
+ Hits 1704 1713 +9
+ Misses 380 371 -9
Partials 17 17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MarvinJWendt
requested changes
Nov 19, 2022
MarvinJWendt
approved these changes
Nov 22, 2022
renovate bot
added a commit
to defenseunicorns/zarf
that referenced
this pull request
Nov 23, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/pterm/pterm](https://togithub.com/pterm/pterm) | require | patch | `v0.12.49` -> `v0.12.50` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>pterm/pterm</summary> ### [`v0.12.50`](https://togithub.com/pterm/pterm/releases/tag/v0.12.50) [Compare Source](https://togithub.com/pterm/pterm/compare/v0.12.49...v0.12.50) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Fixes 🔧 - fix: slice bounds out of range on select printer by [@​mponton](https://togithub.com/mponton) in [pterm/pterm#420 ##### Other Changes - chore(ci): remove macos from matrix by [@​rafaelrubbioli](https://togithub.com/rafaelrubbioli) in [pterm/pterm#412 #### New Contributors - [@​rafaelrubbioli](https://togithub.com/rafaelrubbioli) made their first contribution in [pterm/pterm#412 - [@​mponton](https://togithub.com/mponton) made their first contribution in [pterm/pterm#420 **Full Changelog**: pterm/pterm@v0.12.49...v0.12.50 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yOS4yIiwidXBkYXRlZEluVmVyIjoiMzQuMjkuMiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
sheldonhull
added a commit
to DelineaXPM/ansible-core-collection
that referenced
this pull request
Nov 23, 2022
](https://renovatebot.com){kind=link}
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/pterm/pterm](https://togithub.com/pterm/pterm) | require | patch | `v0.12.49` -> `v0.12.50` | --- ### Release Notes <details> <summary>pterm/pterm</summary> ### [`v0.12.50`](https://togithub.com/pterm/pterm/releases/tag/v0.12.50) [Compare Source](https://togithub.com/pterm/pterm/compare/v0.12.49...v0.12.50) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Fixes 🔧 - fix: slice bounds out of range on select printer by [@​mponton](https://togithub.com/mponton) in [pterm/pterm#420 ##### Other Changes - chore(ci): remove macos from matrix by [@​rafaelrubbioli](https://togithub.com/rafaelrubbioli) in [pterm/pterm#412 #### New Contributors - [@​rafaelrubbioli](https://togithub.com/rafaelrubbioli) made their first contribution in [pterm/pterm#412 - [@​mponton](https://togithub.com/mponton) made their first contribution in [pterm/pterm#420 **Full Changelog**: pterm/pterm@v0.12.49...v0.12.50 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMjkuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIyOS4wIn0=--> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: Sheldon Hull <sheldonhull@users.noreply.github.com>
mend-for-github-com bot
added a commit
to DelineaXPM/terraform-provider-dsv
that referenced
this pull request
Dec 8, 2022
…50 (#38) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/pterm/pterm](https://togithub.com/pterm/pterm) | require | patch | `v0.12.49` -> `v0.12.50` | --- ### Release Notes <details> <summary>pterm/pterm</summary> ### [`v0.12.50`](https://togithub.com/pterm/pterm/releases/tag/v0.12.50) [Compare Source](https://togithub.com/pterm/pterm/compare/v0.12.49...v0.12.50) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Fixes 🔧 - fix: slice bounds out of range on select printer by [@​mponton](https://togithub.com/mponton) in [pterm/pterm#420 ##### Other Changes - chore(ci): remove macos from matrix by [@​rafaelrubbioli](https://togithub.com/rafaelrubbioli) in [pterm/pterm#412 #### New Contributors - [@​rafaelrubbioli](https://togithub.com/rafaelrubbioli) made their first contribution in [pterm/pterm#412 - [@​mponton](https://togithub.com/mponton) made their first contribution in [pterm/pterm#420 **Full Changelog**: pterm/pterm@v0.12.49...v0.12.50 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMjkuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIyOS4wIn0=--> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Noxsios
pushed a commit
to defenseunicorns/zarf
that referenced
this pull request
Mar 8, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/pterm/pterm](https://togithub.com/pterm/pterm) | require | patch | `v0.12.49` -> `v0.12.50` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>pterm/pterm</summary> ### [`v0.12.50`](https://togithub.com/pterm/pterm/releases/tag/v0.12.50) [Compare Source](https://togithub.com/pterm/pterm/compare/v0.12.49...v0.12.50) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Fixes 🔧 - fix: slice bounds out of range on select printer by [@​mponton](https://togithub.com/mponton) in [pterm/pterm#420 ##### Other Changes - chore(ci): remove macos from matrix by [@​rafaelrubbioli](https://togithub.com/rafaelrubbioli) in [pterm/pterm#412 #### New Contributors - [@​rafaelrubbioli](https://togithub.com/rafaelrubbioli) made their first contribution in [pterm/pterm#412 - [@​mponton](https://togithub.com/mponton) made their first contribution in [pterm/pterm#420 **Full Changelog**: pterm/pterm@v0.12.49...v0.12.50 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yOS4yIiwidXBkYXRlZEluVmVyIjoiMzQuMjkuMiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #419
Description
Update InteractiveSelectPrinter.Show to fix out of range issue on
Optionsslice whenDefaultOptionis set and its index is withinmaxHeightof the end of theOptionsarray.Scope
Related Issue
Fixes #419
To-Do Checklist