Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: slice bounds out of range on select printer #420

Merged
merged 2 commits into from Nov 22, 2022
Merged

fix: slice bounds out of range on select printer #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c91ee03
fix: slice bounds out of range on select printer
mponton Nov 18, 2022
8ff8b73
fix: revert original test & add new test
mponton Nov 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions interactive_select_printer.go
View file
Open in desktop
Expand Up @@ -2,6 +2,7 @@ package pterm

import (
"fmt"
"math"
"sort"

"atomicgo.dev/cursor"
Expand Down Expand Up @@ -106,9 +107,9 @@ func (p *InteractiveSelectPrinter) Show(text ...string) (string, error) {
for i, option := range p.Options {
if option == p.DefaultOption {
p.selectedOption = i
if i > 0 {
p.displayedOptionsStart = i - 1
p.displayedOptionsEnd = i - 1 + maxHeight
if i > 0 && len(p.Options) > maxHeight {
p.displayedOptionsEnd = int(math.Min(float64(i-1+maxHeight), float64(len(p.Options))))
p.displayedOptionsStart = p.displayedOptionsEnd - maxHeight
} else {
p.displayedOptionsStart = 0
p.displayedOptionsEnd = maxHeight
Expand Down
10 changes: 10 additions & 0 deletions interactive_select_printer_test.go
View file
Open in desktop
Expand Up @@ -20,6 +20,16 @@ func TestInteractiveSelectPrinter_Show(t *testing.T) {
testza.AssertEqual(t, "d", result)
}

func TestInteractiveSelectPrinter_Show_MaxHeightSlidingWindow(t *testing.T) {
go func() {
keyboard.SimulateKeyPress(keys.Up)
keyboard.SimulateKeyPress(keys.Up)
keyboard.SimulateKeyPress(keys.Enter)
}()
result, _ := pterm.DefaultInteractiveSelect.WithOptions([]string{"a", "b", "c", "d", "e", "f"}).WithDefaultOption("e").Show()
testza.AssertEqual(t, "c", result)
}

func TestInteractiveSelectPrinter_WithDefaultText(t *testing.T) {
p := pterm.DefaultInteractiveSelect.WithDefaultText("default")
testza.AssertEqual(t, p.DefaultText, "default")
Expand Down