Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Build #85 and #86 failed #127

Closed
tferazzi opened this issue Feb 24, 2023 · 4 comments
Closed

Release Build #85 and #86 failed #127

tferazzi opened this issue Feb 24, 2023 · 4 comments
Assignees
@dixler
Labels
area/build impact/regression Something that used to work, but is now broken kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@tferazzi
Copy link

What happened?

Release Build 85 and 86 failed which causes outdated pulumi docker images on AWS ECR Public Gallery and Github Container Registry.

Latest version in both registries is 3.53.1 while it's 3.55 in Dockerhub.

Expected Behavior

To have the latest versions (currently 3.55.0) on Public Gallery and Github Registry as well.

Steps to reproduce

See the release pipeline.
Cannot reproduce the failing tests because they are run in a Pulumi service environment.

Output of pulumi about

CLI
Version 3.55.0
Go Version go1.20
Go Compiler gc

Plugins
NAME VERSION
nodejs v19.5.0

Host
OS ubuntu
Version 20.04
Arch x86_64

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@tferazzi tferazzi added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Feb 24, 2023
@dixler dixler added impact/regression Something that used to work, but is now broken area/build and removed needs-triage Needs attention from the triage team labels Feb 27, 2023
@dixler dixler self-assigned this Feb 27, 2023
@dixler
Copy link
Contributor

dixler commented Feb 27, 2023

Hey! Thanks for bringing this to our attention. Taking a look.

@dixler
Copy link
Contributor

dixler commented Feb 28, 2023 •
edited

It appears that the reason that those releases failed was due to us upgrading go-git which introduced a cgo dependency which broke a number of people's builds.

An issue was opened a while back
go-git/go-git#637

The PR and a release has just been cut so it should be fixed as of
https://github.com/go-git/go-git/releases/tag/v5.6.0

We just have to bump the version on pulumi/pulumi so I will transfer the issue.

Edit: On second thought, I'm going to transfer it back and open a new issue to track bumping the version and link it here

@dixler dixler transferred this issue from pulumi/pulumi-docker-containers Feb 28, 2023
@dixler dixler transferred this issue from pulumi/pulumi Feb 28, 2023
This was referenced Feb 28, 2023
Closed
Merged
bors bot added a commit to pulumi/pulumi that referenced this issue Mar 1, 2023
@bors
Merge #12310
9265512 
12310: Bump go-git to v5.6.0 to remove cgo dependency. r=dixler a=dixler

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. -->

This PR removes a cgo dependency from pulumi which broke builds in pulumi-docker-containers (see pulumi/pulumi-docker-containers#127).

go-git introduced a cgo dependency they have removed the dependency as of https://github.com/go-git/go-git/releases/tag/v5.6.0 and this PR bumps our version of go-git to that version.

Fixes #12309 

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


Co-authored-by: Kyle Dixler <kyle@pulumi.com>
bors bot added a commit to pulumi/pulumi that referenced this issue Mar 1, 2023
@bors
Merge #12310
97fb30e 
12310: Bump go-git to v5.6.0 to remove cgo dependency. r=dixler a=dixler

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. -->

This PR removes a cgo dependency from pulumi which broke builds in pulumi-docker-containers (see pulumi/pulumi-docker-containers#127).

go-git introduced a cgo dependency they have removed the dependency as of https://github.com/go-git/go-git/releases/tag/v5.6.0 and this PR bumps our version of go-git to that version.

Fixes #12309 

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


Co-authored-by: Kyle Dixler <kyle@pulumi.com>
@dixler dixler mentioned this issue Mar 3, 2023
Merged
dixler pushed a commit to pulumi/templates that referenced this issue Mar 3, 2023
This commit pins org.apache.maven.plugins:maven-compiler-plugin to 3.…
5c5e3ff 
…5.1.

to resolve failing builds for UBI images on pulumi-docker-containers.

 pulumi/pulumi-docker-containers#127
@dixler dixler mentioned this issue Mar 3, 2023
Merged
@dixler
Copy link
Contributor

dixler commented Mar 3, 2023

@tferazzi hey. sorry it took so long. I was expecting some upstream changes in the recent release to fix things, but they didn't 🙃

I'm finishing up the last fix for java and it should be publishing again soon.

This was referenced Mar 6, 2023
Merged
Closed
@dixler
Copy link
Contributor

dixler commented Mar 7, 2023

Hey, I believe this should be fixed now. LMK if it's not.

@dixler dixler added the resolution/fixed This issue was fixed label Mar 7, 2023
@dixler dixler closed this as completed Mar 7, 2023
dirien pushed a commit to dirien/templates that referenced this issue Mar 29, 2023
@dirien
This commit pins org.apache.maven.plugins:maven-compiler-plugin to 3.…
37a7eeb 
…5.1.

to resolve failing builds for UBI images on pulumi-docker-containers.

 pulumi/pulumi-docker-containers#127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dixler dixler

Labels
area/build impact/regression Something that used to work, but is now broken kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dixler @tferazzi