Cross test max items one #1910
Merged
Cross test max items one #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1910 +/- ##
==========================================
+ Coverage 60.26% 62.04% +1.77%
==========================================
Files 328 327 -1
Lines 44331 36905 -7426
==========================================
- Hits 26717 22897 -3820
+ Misses 16118 12511 -3607
- Partials 1496 1497 +1 ☔ View full report in Codecov by Sentry. |
t0yv0
reviewed
Apr 30, 2024
|
|
||
| maxItems := rapid.IntRange(0, 1).Draw(t, "maxItemsOne") | ||
| maxPropValues := 3 | ||
| if maxItems == 1 { |
There was a problem hiding this comment.
Maybe a quick comment here that we're only testing happy path for now.
VenelinMartinov
added a commit
that referenced
this pull request
May 2, 2024
This one adds an escape hatch for empty strings and lists as these are currently broken. I'll add the tests which repro this in the next PR. Stacked on #1910
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1861
This adds maxItemsOne generation in the rapid generated schemas.
Stack on #1909