Eject with missing nodes #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aq17
approved these changes
Nov 2, 2022
aq17
pushed a commit
that referenced
this pull request
Nov 17, 2022
* Eject with missing nodes * Allow ejecting nodes like foo:bar * Inject missing config nodes * Provide raw config names to PCL * CL * Fix tests * Support config logcal names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes three adjustments.
Ejectto proceed with missing nodes.Ejectwhen it looks like it is a missing config value. This is a best effort heuristic but works in the simple case.foo:bardon't get ejected asfooBar(which is invalid). (This behavior requires Support a logical name for config vars pulumi#11231)