[sdk/go] chore: update some notes and make some lint #10984

asjdf · 2022-10-10T09:13:38Z

I updated some notes, updated the deprecated functions, and make some lint.

Reason for error string change: error string should not be capitalized or end with a punctuation mark.

According to the p/p readme, I think it is time to remove some deprecated function like ioutil.ReadFile. #6703

Checklist

I have run tests
I have run make changelog and committed the changelog/pending/<file> documenting my change
Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

about error string: error string should not be capitalized or end with punctuation mark

pulumi-bot · 2022-10-10T09:14:24Z

Changelog

[uncommitted] (2022-10-11)

Miscellaneous

[sdk/go] Update notes, update the deprecated functions, make some lint.

sdk/go/auto/optdestroy/optdestroy.go

sdk/dotnet/cmd/pulumi-language-dotnet/main.go

sdk/go/auto/opthistory/opthistory.go

sdk/go/auto/optrefresh/optrefresh.go

sdk/go/auto/optup/optup.go

sdk/go/common/resource/properties_diff.go

sdk/go/common/util/cmdutil/spinner.go

sdk/go/common/util/gitutil/git.go

sdk/python/python.go

Co-authored-by: Fraser Waters <frassle@gmail.com>

Frassle · 2022-10-10T21:30:34Z

bors merge

10984: [sdk/go] chore: update some notes and make some lint r=Frassle a=asjdf I updated some notes, updated the deprecated functions, and make some lint. Reason for error string change: error string should not be capitalized or end with a punctuation mark. According to the p/p [readme](https://github.com/pulumi/pulumi#languages), I think it is time to remove some deprecated function like ioutil.ReadFile. #6703 ## Checklist - [x] I have run tests - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change - [x] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version  Co-authored-by: 杨成锴 <homeboyc@foxmail.com>

bors · 2022-10-10T21:50:23Z

Build failed:

bors-ok

AaronFriel

Made a number of suggestions and requested changes.

The change to types_builtin.go seems likely to be undone next time the file is generated.

sdk/go/auto/local_workspace.go

sdk/dotnet/cmd/pulumi-language-dotnet/main.go

sdk/go/auto/optdestroy/optdestroy.go

sdk/go/auto/opthistory/opthistory.go

sdk/go/auto/optrefresh/optrefresh.go

sdk/go/pulumi/log.go

sdk/go/pulumi/mocks.go

sdk/go/pulumi/types_builtins.go

sdk/nodejs/cmd/pulumi-language-nodejs/main.go

sdk/python/cmd/pulumi-language-python/main.go

AaronFriel · 2022-10-11T02:39:45Z

@asjdf Thanks for the contribution, sorry for all the late breaking suggestions here, but it felt appropriate to put them in one place.

@Frassle if any of these suggestions seem off, let me know. I think the change to type_builtins.go will have to be reverted as I note above, due to it being a generated file?

Tomorrow I plan to add a /squash-and-merge slash command for us to use in cases like this where we might want to apply suggestions. Can we hold off on merging until that's in?

AaronFriel

Requested a change on the types_builtin.go in particular. The remainder of the suggestions I made could be applied in a follow up PR, but this is a convenient place to make them.

susanev · 2022-10-11T02:41:46Z

@asjdf thank you for taking the time to open this pr!! ❤️

Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>

asjdf · 2022-10-11T06:17:24Z

Thank you all for taking the time to review my pr. ❤

asjdf · 2022-10-11T06:49:33Z

Requested a change on the types_builtin.go in particular. The remainder of the suggestions I made could be applied in a follow up PR, but this is a convenient place to make them.

I think you are right, so I revert the changes in types_builtin.go. I'm sorry for my hasty changes in types_builtin.go.

AaronFriel

Looks good to me, thank you!

bors merge

10984: [sdk/go] chore: update some notes and make some lint r=AaronFriel a=asjdf I updated some notes, updated the deprecated functions, and make some lint. Reason for error string change: error string should not be capitalized or end with a punctuation mark. According to the p/p [readme](https://github.com/pulumi/pulumi#languages), I think it is time to remove some deprecated function like ioutil.ReadFile. #6703 ## Checklist - [x] I have run tests - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change - [x] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version  Co-authored-by: 杨成锴 <homeboyc@foxmail.com>

bors · 2022-10-11T19:32:30Z

Build failed:

bors-ok

AaronFriel · 2022-10-11T19:56:37Z

@asjdf I'll need to take another pass, as it looks tests are failing with an error that points to a string formatting change:

error: failed to load language plugin : Could not automatically download and install language plugin 'pulumi-language-', install the plugin using pulumi plugin install language .
Underlying error: 403 HTTP error fetching plugin from https://api.github.com/repos/pulumi/pulumi-/releases/latest

asjdf · 2022-10-11T23:24:57Z

@asjdf I'll need to take another pass, as it looks tests are failing with an error that points to a string formatting change:

error: failed to load language plugin : Could not automatically download and install language plugin 'pulumi-language-', install the plugin using pulumi plugin install language .

Underlying error: 403 HTTP error fetching plugin from https://api.github.com/repos/pulumi/pulumi-/releases/latest

I'm really sorry that this pr has taken up so much of your time. Thank you very much for your help.❤️

AaronFriel · 2022-10-12T00:56:08Z

@asjdf thank you for taking the time to make this contribution! It's long overdue cleanup to be consistent with Go's style guide.

I've started a new PR #11002 based off this branch to see why those some of those checks failed. It looks like the main issue is Go's behavior and requirements for pointer vs value receivers with marshaling.

I found this Go playground entry (the same as linked above) which shows that Go's behavior here seems inconsistent. I learned the hard way to be careful changing methods from pointer receivers to value receivers early on.

asjdf · 2022-10-12T00:59:49Z

@asjdf thank you for taking the time to make this contribution! It's long overdue cleanup to be consistent with Go's style guide.

I've started a new PR #11002 based off this branch to see why those some of those checks failed. It looks like the main issue is Go's behavior and requirements for pointer vs value receivers with marshaling.

I found this Go playground entry (the same as linked above) which shows that Go's behavior here seems inconsistent. I learned the hard way to be careful changing methods from pointer receivers to value receivers early on.

Thank you for your help and looks like I can turn this pr off?

AaronFriel · 2022-10-12T01:29:32Z

@asjdf if you want to click "Allow edits from maintainers", I can push my changes back onto this branch and merge.

AaronFriel · 2022-10-17T20:43:57Z

Closing in favor of #11002

11002: Test changes to #10984 r=AaronFriel a=AaronFriel This is a rebase and squash of #10984 with an additional commit added to satisfy `make lint` and revert a few changes to methods to use value receivers, where the original PR altered marshaling/unmarshaling behavior. Co-authored-by: 杨成锴 <homeboyc@foxmail.com> Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>

11002: Reimplement #10984 r=AaronFriel a=AaronFriel This is a rebase and squash of #10984 with an additional commit added to satisfy `make lint` and revert a few changes to methods to use value receivers, where the original PR altered marshaling/unmarshaling behavior. 11031: prepare for next release (v3.43.1) r=AaronFriel a=pulumi-bot 11059: (pulumi-bot) Synced file(s) with pulumi/pulumi-yaml r=aq17 a=pulumi-bot Synced local file(s) with [pulumi/pulumi-yaml](https://github.com/pulumi/pulumi-yaml). This PR syncs changes to the codegen'd PCL files from the latest `pulumi/yaml` release <details> <summary>Changed files</summary> <ul> <li>Created local directory <code>pkg/codegen/testing/test/testdata/transpiled_examples</code> and copied all sub files/folders from remote directory <code>pkg/tests/transpiled_examples</code></li> </ul> </details> --- This PR was created automatically by the [repo-file-sync-action](https://github.com/BetaHuhn/repo-file-sync-action) workflow run [#3269786749](https://github.com/pulumi/pulumi-yaml/actions/runs/3269786749) Co-authored-by: 杨成锴 <homeboyc@foxmail.com> Co-authored-by: Aaron Friel <mayreply@aaronfriel.com> Co-authored-by: pulumi-bot <null> Co-authored-by: Alex Qiu <aqiu@pulumi.com>

asjdf added 2 commits October 9, 2022 22:58

chore: update some note and do some lint

c8dcb7b

about error string: error string should not be capitalized or end with punctuation mark

update(changelog)

e0d4449

Frassle reviewed Oct 10, 2022

View reviewed changes

asjdf and others added 3 commits October 10, 2022 18:05

typo: apply suggestions from code review

81df7de

Co-authored-by: Fraser Waters <frassle@gmail.com>

Merge branch 'pulumi:master' into master

9f31197

typo: apply suggestions from code review

dab81be

Co-authored-by: Fraser Waters <frassle@gmail.com>

Frassle approved these changes Oct 10, 2022

View reviewed changes

AaronFriel reviewed Oct 11, 2022

View reviewed changes

AaronFriel requested changes Oct 11, 2022

View reviewed changes

chore: apply suggestions from code review

2ae8ae3

Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>

asjdf added 2 commits October 11, 2022 14:40

lint: fix format error and simplify the code

a7e68c2

[sdk/go] Revert change in types_builtins.go

a09bb93

asjdf requested a review from AaronFriel October 11, 2022 06:55

AaronFriel approved these changes Oct 11, 2022

View reviewed changes

AaronFriel mentioned this pull request Oct 13, 2022

Reimplement #10984 #11002

Merged

AaronFriel closed this Oct 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[sdk/go] chore: update some notes and make some lint #10984

[sdk/go] chore: update some notes and make some lint #10984

asjdf commented Oct 10, 2022

pulumi-bot commented Oct 10, 2022 •

edited

Frassle commented Oct 10, 2022

bors bot commented Oct 10, 2022

AaronFriel left a comment

AaronFriel commented Oct 11, 2022

AaronFriel left a comment

susanev commented Oct 11, 2022

asjdf commented Oct 11, 2022

asjdf commented Oct 11, 2022 •

edited

AaronFriel left a comment

bors bot commented Oct 11, 2022

AaronFriel commented Oct 11, 2022

asjdf commented Oct 11, 2022

AaronFriel commented Oct 12, 2022

asjdf commented Oct 12, 2022 •

edited

AaronFriel commented Oct 12, 2022

AaronFriel commented Oct 17, 2022

[sdk/go] chore: update some notes and make some lint #10984

[sdk/go] chore: update some notes and make some lint #10984

Conversation

asjdf commented Oct 10, 2022

Checklist

pulumi-bot commented Oct 10, 2022 • edited

Changelog

[uncommitted] (2022-10-11)

Miscellaneous

Frassle commented Oct 10, 2022

bors bot commented Oct 10, 2022

AaronFriel left a comment

Choose a reason for hiding this comment

AaronFriel commented Oct 11, 2022

AaronFriel left a comment

Choose a reason for hiding this comment

susanev commented Oct 11, 2022

asjdf commented Oct 11, 2022

asjdf commented Oct 11, 2022 • edited

AaronFriel left a comment

Choose a reason for hiding this comment

bors bot commented Oct 11, 2022

AaronFriel commented Oct 11, 2022

asjdf commented Oct 11, 2022

AaronFriel commented Oct 12, 2022

asjdf commented Oct 12, 2022 • edited

AaronFriel commented Oct 12, 2022

AaronFriel commented Oct 17, 2022

pulumi-bot commented Oct 10, 2022 •

edited

asjdf commented Oct 11, 2022 •

edited

asjdf commented Oct 12, 2022 •

edited