Reimplement #10984 #11002
Merged
Reimplement #10984 #11002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2022-10-13)Miscellaneous
|
AaronFriel
force-pushed
the
friel/asjfd-testing
branch
2 times, most recently
from
5733894
to
4edd7ff
Compare
3 tasks
* about error string: error string should not be capitalized or end with punctuation mark * apply suggestions from code review * lint: fix format error and simplify the code Co-authored-by: Fraser Waters <frassle@gmail.com> Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
AaronFriel
force-pushed
the
friel/asjfd-testing
branch
from
557c5ec
to
ab1ec4f
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 17, 2022
11002: Test changes to #10984 r=AaronFriel a=AaronFriel This is a rebase and squash of #10984 with an additional commit added to satisfy `make lint` and revert a few changes to methods to use value receivers, where the original PR altered marshaling/unmarshaling behavior. Co-authored-by: 杨成锴 <homeboyc@foxmail.com> Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
mmdriley
added a commit
to mmdriley/pulumi
that referenced
this pull request
Apr 5, 2023
The call to `SetModTime` was removed in pulumi#11002 but the comment stayed around. The `nolint` directive had been added in pulumi#1494 to excuse the (now-removed) use of `SetModTime`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase and squash of #10984 with an additional commit added to satisfy
make lintand revert a few changes to methods to use value receivers, where the original PR altered marshaling/unmarshaling behavior.