Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support a logical name for config vars #11231

Merged
merged 1 commit into from Nov 2, 2022
Merged

Support a logical name for config vars #11231

merged 1 commit into from Nov 2, 2022

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Nov 2, 2022

Fixes #11230

@iwahbe iwahbe requested a review from aq17 November 2, 2022 19:40
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2022-11-02)

Features

  • [programgen/{dotnet,go,java,nodejs,python}] Support a logical name for config vars
    #11231

aq17
aq17 reviewed Nov 2, 2022
View reviewed changes
Copy link
Contributor

@aq17 aq17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@iwahbe iwahbe requested a review from aq17 November 2, 2022 19:46
@iwahbe iwahbe mentioned this pull request Nov 2, 2022
Merged
@aq17
Copy link
Contributor

aq17 commented Nov 2, 2022

bors merge

@iwahbe
Copy link
Member Author

iwahbe commented Nov 2, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 2, 2022

Already running a review

@bors
Copy link
Contributor

bors bot commented Nov 2, 2022

Build succeeded:

@bors bors bot merged commit 35d2a6e into master Nov 2, 2022
@pulumi-bot pulumi-bot deleted the iwahbe/support-config-logical-names branch November 2, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aq17 aq17 aq17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support logical names for config values in PCL
3 participants
@iwahbe @pulumi-bot @aq17