Fix NodeJS SDK when a component is using another component from the same schema as a property #11467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
Changelog[uncommitted] (2022-11-25)Bug Fixes
|
|
/run-codegen |
|
bors r+ |
|
Build succeeded: |
iwahbe
added a commit
that referenced
this pull request
Dec 9, 2022
iwahbe
added a commit
that referenced
this pull request
Dec 9, 2022
Adjust CL for multiple languages.
bors bot
added a commit
that referenced
this pull request
Dec 9, 2022
11606: Remove .NET type imports and add a test for #11467 r=iwahbe a=iwahbe This is follow up for #11467. It adjusts a SDK generation test to include the new feature. I also remove the resource import code for .NET, since it broke the test and we use absolute paths at this point. Co-authored-by: Ian Wahbe <ian@wahbe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code generated for the NodeJS SDK is broken when a component is using another component from the same schema as a property where the token doesn't start with
<provider-name>:index:.Fixes #11466
I've created a test project to verify the issue and to verify the fix:
Checklist
make changelogand committed thechangelog/pending/<file>documenting my change