[area/nodejs] Take engines property into account when engine-strict appear in .npmrc file #9249
Conversation
| // This is what node does as described in the npm docs | ||
| // https://docs.npmjs.com/cli/v8/configuring-npm/npmrc#comments | ||
| return ini.parse(npmRc); | ||
| } catch { |
There was a problem hiding this comment.
Wonder if we should just allow this error to bubble up. It's probably something like bad permissions and having that explict error might be better than silently ignoring if engine-strict is set?
There was a problem hiding this comment.
I followed the same approach as with packageObjectFromProjectRoot where we just return an empty object if we are unable to read or parse it. Do you think it is likely that an error would occur when we are only reading the file?
There was a problem hiding this comment.
Only errors I can think likely are permission issues. It's probably rare enough to not really worry either way.
There was a problem hiding this comment.
Would we have a way of raising a warning here instead - to help the user if it is some kind of permissions issue?
|
thanks @danielrbradley for the review 🙏 |
Description
Fixes #9201
Checklist