Return errors on parse failures for config.Try*

[iwahbe]

Description

config.Try* returns an error message if a config key is missing, but there is currently no way to guarantee that a key is pulled from the config. When a non-string primitive key is tried, a failure to parse leads returns the type appropriate zero value. This is super counterintuitive to me. Especially since config.TryObject does return a parse error when appropriate.

This is a breaking change, but it is hard to imagine a situation where config.Try* is used correctly. Therefore I believe the change is appropriate.

This PR changes the behavior of config.Try* to return an error if either the requested key is missing in the config or if the key is invalid for the requested type.

Example

cfg := config.New(ctx, "dev")
v, err := cfg.TryInt("key")
if errors.Is(err, config.ErrMissingVar) {
    // Set a default
    v = 42
} else if err != nil {
    // We set the value incorrectly
    panic(fmt.Errorf(`Attempted to pass default value "%s" as float64: %w`, cfg.Require("key"), err))
}

PS: We do the same thing for config.Require*, and I made the same change.

Checklist

• I have added tests that prove my fix is effective or that my feature works

• I have updated the CHANGELOG-PENDING file with my change

• Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

[pgavlin]

CHANGELOG_PENDING needs to be cleaned up; LGTM otherwise.

[pgavlin]

Nit: I'd panic with an error here to make it a bit easier to recover if necessary.

Suggested change

	panic(fmt.Sprintf(format, a...))
	panic(fmt.Errorf(format, a...))

[github-actions]

Diff for pulumi-azuread with merge commit 2ce4e97

[github-actions]

Diff for pulumi-random with merge commit 2ce4e97

[github-actions]

Diff for pulumi-kubernetes with merge commit 2ce4e97

[github-actions]

Diff for pulumi-gcp with merge commit 2ce4e97

[github-actions]

Diff for pulumi-azure with merge commit 2ce4e97

[github-actions]

Diff for pulumi-aws with merge commit 2ce4e97

[github-actions]

Diff for pulumi-random with merge commit a14052d

[github-actions]

Diff for pulumi-azuread with merge commit a14052d

[github-actions]

Diff for pulumi-kubernetes with merge commit a14052d

[github-actions]

Diff for pulumi-gcp with merge commit a14052d

[github-actions]

Diff for pulumi-azuread with merge commit b3ada87

[github-actions]

Diff for pulumi-random with merge commit b3ada87

[github-actions]

Diff for pulumi-kubernetes with merge commit b3ada87

[github-actions]

Diff for pulumi-azure with merge commit a14052d

[github-actions]

Diff for pulumi-aws with merge commit a14052d

[github-actions]

Diff for pulumi-gcp with merge commit b3ada87

[github-actions]

Diff for pulumi-azure with merge commit b3ada87