Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return errors on parse failures for config.Try* #9407

Merged
merged 13 commits into from Apr 20, 2022
Merged

Return errors on parse failures for config.Try* #9407

merged 13 commits into from Apr 20, 2022

Commits on Apr 15, 2022

  1. Return a concrete type when missing a key

    @iwahbe
    iwahbe committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    12e1b6c View commit details
    Browse the repository at this point in the history

  2. Add tests + fix implementation

    @iwahbe
    iwahbe committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    3d1269a View commit details
    Browse the repository at this point in the history

  3. Return an error for when parsing fails

    @iwahbe
    iwahbe committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    908186e View commit details
    Browse the repository at this point in the history

  4. Implement the same fix for errors

    @iwahbe
    iwahbe committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    8dfebdf View commit details
    Browse the repository at this point in the history

  5. Update changelog

    @iwahbe
    iwahbe committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    0924f6f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into iwahbe/improve-go-try-errors

    @iwahbe
    iwahbe committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    ad0e40c View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2022

  1. Update CHANGELOG_PENDING.md

    @iwahbe
    iwahbe committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    5f329b0 View commit details
    Browse the repository at this point in the history

  2. Remove contract.Failf from require

    @iwahbe
    iwahbe committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    6de1848 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into iwahbe/improve-go-try-errors

    @iwahbe
    iwahbe committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    e7a009a View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Fix nit + lower conversion panic

    @iwahbe
    iwahbe committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    1c76854 View commit details
    Browse the repository at this point in the history

  2. Fix test

    @iwahbe
    iwahbe committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    c15e62a View commit details
    Browse the repository at this point in the history

  3. Link correctly

    @iwahbe
    iwahbe committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    59a4786 View commit details
    Browse the repository at this point in the history

  4. Fix indentation + revert lowerConversion change

    @iwahbe
    iwahbe committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    4c524f0 View commit details
    Browse the repository at this point in the history