Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong assumption of Chrome exec path on Apple Silicon M1 #6641

Closed
kenny-y opened this issue Dec 1, 2020 · 8 comments
Closed

Wrong assumption of Chrome exec path on Apple Silicon M1 #6641

kenny-y opened this issue Dec 1, 2020 · 8 comments

Comments

@kenny-y
Copy link

kenny-y commented Dec 1, 2020

I'll make this as short as possible since it's very straightforward (I bet you like it this way for this particular issue)

In Launcher.js:79

        let chromeExecutable = executablePath;
        if (os.arch() === 'arm64') {
            chromeExecutable = '/usr/bin/chromium-browser';
        }
        else if (!executablePath) {

The path provided to puppeteer is: /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

I'm using ARM64 Node.js v15 compiled by this link: https://www.reddit.com/r/apple/comments/jyfg4m/nodejs_running_native_on_apple_silicon_m1_mac_mini/

@nc
Copy link

nc commented Dec 12, 2020

+1

@yhatt
Copy link

yhatt commented Dec 17, 2020

Related: #6495 #6634

@bjornlll
Copy link

Thanks for pointing us all in the right direction, @kenny-y!

        // node_modules/puppeteer-core/lib/cjs/puppeteer/node/Launcher.js L:73
        if (os.arch() === 'arm64' && false) {
            chromeExecutable = '/usr/bin/chromium-browser';
        }

👆 I patched it directly in my node_modules folder. Will do until an official fix comes out.

@jhoopmann
Copy link

jhoopmann commented Jun 25, 2021

+1

and I almost wanted to remount my root as writable to link the chromium browser binary in /usr/bin. Still not fixed.

@schappim
Copy link

+1

@stale
Copy link

stale bot commented Jun 23, 2022

We're marking this issue as unconfirmed because it has not had recent activity and we weren't able to confirm it yet. It will be closed if no further activity occurs within the next 30 days.

@stale stale bot added the unconfirmed label Jun 23, 2022
@schappim
Copy link

What do you need to confirm?

@stale
Copy link

stale bot commented Jul 27, 2022

We are closing this issue. If the issue still persists in the latest version of Puppeteer, please reopen the issue and update the description. We will try our best to accomodate it!

@stale stale bot closed this as completed Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants