[7.0.4] Type defaultViewport can't be null (to take all window space)

[spinlud]

• Puppeteer version: 7.0.4
• Node.js version: 12.x

Usually, to make viewport taking all the available space in window we need to set defaultViewport to null:

const puppeteer = require('puppeteer');

(async () => {
    const windowWidth = 1472;
    const windowHeight = 828;
    
    const browser = await puppeteer.launch({
        headless: false,
        args: [
            "--enable-automation",
            "--start-maximized",
            `--window-size=${windowWidth},${windowHeight}`,
            "--no-sandbox",
            "--disable-setuid-sandbox",
            "--disable-dev-shm-usage",
            "--proxy-server='direct://",
            "--proxy-bypass-list=*",
            "--disable-gpu",
            "--disable-accelerated-2d-canvas",
        ],
        defaultViewport: null,
        pipe: true,
    });

    const page = (await browser.pages())[0];
    const url = 'https://www.blizzard.com/en-us/';

    await page.goto(url, {
        waitUntil: 'load',
    });
})();

This doesn't seem to be allowed in typescript (defaultViewport must be of type Viewport or undefined):

But leaving it undefined does not give the desired result.

[Niek]

Can confirm the same issue.

[jef]

Remove --window-size=${windowWidth},${windowHeight} and defaultViewport in favor of --start-maximized.

[christian-bromann]

Proposed a fix for this in #6942