Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shrinked viewport for devtools package #6487

Merged
merged 5 commits into from Mar 1, 2021
Merged

Fix shrinked viewport for devtools package #6487

merged 5 commits into from Mar 1, 2021

Conversation

L0tso
Copy link
Contributor

@L0tso L0tso commented Feb 22, 2021

Proposed changes

Fix #6471

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann
Copy link
Member

@L0tso can you run the tests and see if they pass?

@L0tso
Copy link
Contributor Author

L0tso commented Feb 23, 2021

@christian-bromann Ohh, I thought PR was opened as draft :(
I have got some issues with this fix

  1. TS error from Puppeteer
    Type 'null' is not assignable to type 'Viewport | undefined' [7.0.4] Type defaultViewport can't be null (to take all window space) puppeteer/puppeteer#6885
  2. Broken snapshots
    image
    Should I close PR until the issues isn't resolved? Or add // @ts-ignore and update snapshots?

@christian-bromann
Copy link
Member

Please update your branch and update the screenshot, thanks!

@dylang
Copy link
Contributor

dylang commented Feb 23, 2021

This might be related to the issue that @L0tso is running into:
puppeteer/puppeteer#6885

@dylanlive
Copy link
Contributor

Watching this. I may want to pull it into #6508 if it is merged.

update snapshots
Co-authored-by: Christian Bromann <github@christian-bromann.com>
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shrinked browser viewport while running the test
4 participants