Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: page.goto options type should be optional #6038

Merged
merged 1 commit into from Jun 18, 2020
Merged

fix: page.goto options type should be optional #6038

merged 1 commit into from Jun 18, 2020

Commits on Jun 18, 2020

  1. fix: page.goto options type should be optional 

    The TypeScript definition erroneously made `options` required. We can
fix it by providing a default value, which means users calling the
function will be able to leave it blank without TS complaining.

Issues like this are a +1 to porting our tests to TypeScript in order to
catch these on our own test suite, so that's something we should look into.
    @jackfranklin
    jackfranklin committed Jun 18, 2020
    Copy the full SHA
    6ff34ff View commit details
    Browse the repository at this point in the history