Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: page.goto options type should be optional #6038

Merged
merged 1 commit into from Jun 18, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion new-docs/puppeteer.frame.goto.md
Expand Up @@ -7,7 +7,7 @@
<b>Signature:</b>

```typescript
goto(url: string, options: {
goto(url: string, options?: {
referer?: string;
timeout?: number;
waitUntil?: PuppeteerLifeCycleEvent | PuppeteerLifeCycleEvent[];
Expand Down
2 changes: 1 addition & 1 deletion new-docs/puppeteer.page.goto.md
Expand Up @@ -7,7 +7,7 @@
<b>Signature:</b>

```typescript
goto(url: string, options: WaitForOptions & {
goto(url: string, options?: WaitForOptions & {
referer?: string;
}): Promise<HTTPResponse>;
```
Expand Down
2 changes: 1 addition & 1 deletion src/FrameManager.ts
Expand Up @@ -412,7 +412,7 @@ export class Frame {
referer?: string;
timeout?: number;
waitUntil?: PuppeteerLifeCycleEvent | PuppeteerLifeCycleEvent[];
}
} = {}
): Promise<HTTPResponse | null> {
return await this._frameManager.navigateFrame(this, url, options);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Page.ts
Expand Up @@ -838,7 +838,7 @@ export class Page extends EventEmitter {

async goto(
url: string,
options: WaitForOptions & { referer?: string }
options: WaitForOptions & { referer?: string } = {}
): Promise<HTTPResponse> {
return await this._frameManager.mainFrame().goto(url, options);
}
Expand Down