Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(launcher): fix installation error on Apple M1 chips #7099

Merged
merged 4 commits into from Apr 19, 2021
Merged

feat(launcher): fix installation error on Apple M1 chips #7099

merged 4 commits into from Apr 19, 2021

Commits on Apr 18, 2021

  1. feat(launcher): fix installation error on Apple M1 chips 

    The previous logic assumed that an arm64 arch is only available in
Linux. WIth Apple's arm64 M1 Chip this assumption isn't true anymore.

Currently there are no official MacOS arm64 chromium builds available,
but we can make use of the excellent Rosetta feature in MacOS that
allows us to run x86 binaries on M1.

Once native MacOS arm64 chromium builds are available we should switch to
those.

Fixes puppeteer#6622
    @marvinhagemeister
    marvinhagemeister committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    8207157 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2021

  1. Update src/node/BrowserFetcher.ts

    @mathiasbynens
    mathiasbynens committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    50a973f View commit details
    Browse the repository at this point in the history

  2. Update src/node/Launcher.ts

    @mathiasbynens
    mathiasbynens committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    38451e6 View commit details
    Browse the repository at this point in the history

  3. Update src/node/install.ts

    @mathiasbynens
    mathiasbynens committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    774d049 View commit details
    Browse the repository at this point in the history