feat(launcher): fix installation error on Apple M1 chips #7099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous logic assumed that an arm64 arch is only available in Linux. WIth Apple's arm64 M1 Chip this assumption isn't true anymore. Currently there are no official MacOS arm64 chromium builds available, but we can make use of the excellent Rosetta feature in MacOS that allows us to run x86 binaries on M1. Once native MacOS arm64 chromium builds are available we should switch to those. Fixes puppeteer#6622
mathiasbynens
approved these changes
Apr 19, 2021
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic assumed that an arm64 arch is only available in Linux. WIth Apple's arm64 M1 Chip this assumption isn't true anymore.
Currently there are no official MacOS arm64 chromium builds available, but we can make use of the excellent Rosetta feature in MacOS that allows us to run x86 binaries on M1.
Once official native MacOS arm64 chromium builds are available we should switch to those.
Fixes #6622