Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): revert "feat(typescript): allow using puppeteer without dom lib" #7829

Merged
merged 2 commits into from Dec 10, 2021

Conversation

johanbay
Copy link
Collaborator

@johanbay johanbay commented Dec 9, 2021

Reverts #6998

We unfortunately have to revert this commit for two reasons:

  1. The approach for generating types.d.ts implemented in the commit invalidates triple-slash compiler directives since it prepends a declaration before the types.d.ts generated by api-extractor.
    In particular, the directive /// <reference types="node" /> in the final types.d.ts is ignored by the typescript compiler making module resolution fail.
  2. The commit makes Puppeteer types ship without DOM types per default. This is not ideal since Puppeteer (and usage of Puppeteer) relies heavily on interacting with DOM elements.

@OrKoN OrKoN merged commit 02c9af6 into main Dec 10, 2021
@OrKoN OrKoN deleted the revert-6998-allow-usage-without-dom-types branch December 10, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants