fix: remove viewport conditions in waitForSelector
#9087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please see my comment here: #8954 (comment) |
jrandolf
changed the title
scrollHeight and scrollWidthwaitForSelector
jrandolf
force-pushed
the
fix-1
branch
2 times, most recently
from
7882c57
to
4fa6c70
Compare
OrKoN
approved these changes
Oct 10, 2022
This was referenced Oct 10, 2022
Closed
Closed
Closed
Merged
mmk
reviewed
Nov 8, 2022
| rect.left < self.innerWidth && | ||
| rect.top < self.innerHeight | ||
| ); | ||
| return rect.width > 0 && rect.height > 0 && rect.right > 0 && rect.bottom > 0; |
There was a problem hiding this comment.
Shouldn't this part of the expression have also been removed?
rect.right > 0 && rect.bottom > 0
For example, rect.bottom is negative if the element is above the current viewport.
There was a problem hiding this comment.
I was just writing a bug report while I saw this comment - submitted #9232 anyway so others can find this more easily :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the viewport conditions in
waitForSelector.See discussion: #8954 (comment)