Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coerce_numbers_to_str option in StringSchema #1262

Conversation

NeevCohen
Copy link
Contributor

@NeevCohen NeevCohen commented Apr 3, 2024

Change Summary

Adding coerce_numbers_to_str option in StringSchema typed dict definition, fixing the failing tests in pydantic side

Related issue number

pydantic/pydantic#9137

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@NeevCohen
Copy link
Contributor Author

please review

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

codspeed-hq bot commented Apr 3, 2024

CodSpeed Performance Report

Merging #1262 will not alter performance

Comparing NeevCohen:fix/coerce-numbers-to-str-in-string-schema (87ddbd1) with main (683c5a3)

Summary

✅ 155 untouched benchmarks

@sydney-runkle sydney-runkle merged commit 4b82169 into pydantic:main Apr 4, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants