New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for field level number to str coercion option #9137
Add support for field level number to str coercion option #9137
Conversation
CodSpeed Performance ReportMerging #9137 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Approving now, will merge once we get that new core version ready :).
@sydney-runkle Awesome! Thanks a lot! Just need to remember to remove the xfails from the tests 😄 |
Once we merge this PR #9153, you can pull that change in and remove your xfails! |
@NeevCohen, that PR is now merged! |
Hmm, looks like tests are still failing... |
Going to go ahead and release 2.7 beta, but we can get this across the line this week + get it into the official release :). |
@sydney-runkle I figured out the issue. In core, I forgot to add the I opened a PR fixing that issue, pydantic/pydantic-core#1262 |
Awesome, no worries at all. We can get that into the next |
Could you pull in the changes from
|
I'll review your other PR shortly - looking forward to it!! Just want to get 2.7 out first :). |
…-number-to-str-coercion
Change Summary
This change adds support for field level number to str coercion option as requested in #8383.
Support in pydantic-core has already been implemented in pydantic/pydantic-core@c607fd8.
This change requires a new pydantic-core version which includes the above commit. Opening this PR now to remember to merge it once a new core version comes out.
Related issue number
Fix #8383
Checklist