Don't always require typing.Generic as a base for partially parametrized models #7119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
9232467
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d7323456.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://dmontagu-stop-always-requiri.pydantic-docs2.pages.dev |
dmontagu
force-pushed
the
dmontagu/stop-always-requiring-typing-generic
branch
from
47d9928
to
9232467
Compare
|
please review |
1 task
adriangb
approved these changes
Aug 14, 2023
dapper91
added a commit
to dapper91/pydantic-xml
that referenced
this pull request
Aug 17, 2023
dapper91
added a commit
to dapper91/pydantic-xml
that referenced
this pull request
Aug 17, 2023
dapper91
added a commit
to dapper91/pydantic-xml
that referenced
this pull request
Aug 17, 2023
dapper91
added a commit
to dapper91/pydantic-xml
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6980
I won't be surprised if there are still cases that aren't properly handled by this change, but this resolves the reported issue, and given the complexity of the generics stuff I think our best bet in the long run is to just rely on converting reported issues into tests, and making sure all tests pass.
Selected Reviewer: @adriangb