Reflect namedtuple default values during validation #7144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
201f6cf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7f6e1533.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://dmontagu-namedtuple-defaults.pydantic-docs2.pages.dev |
|
please review |
dmontagu
commented
Aug 16, 2023
| @@ -1130,7 +1130,9 @@ def _namedtuple_schema(self, namedtuple_cls: Any, origin: Any) -> core_schema.Co | |||
|
|
|||
| arguments_schema = core_schema.arguments_schema( | |||
| [ | |||
| self._generate_parameter_schema(field_name, annotation) | |||
| self._generate_parameter_schema( | |||
| field_name, annotation, default=namedtuple_cls._field_defaults.get(field_name, Parameter.empty) | |||
There was a problem hiding this comment.
Though this looks like a private attribute access, this _field_defaults attribute is explicitly present in the type stubs for NamedTuple — I think it's intended for public access, just has an underscore to prevent name collisions.
There was a problem hiding this comment.
There was a problem hiding this comment.
adriangb
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7134
Selected Reviewer: @hramezani