fix: type-error on model_validator in wrap mode #7496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #7154, `ModelWrapValidator` is generic, and if `reportUnknownVariableType` is enabled in Pyright the import will be a type-error. I think it was an oversight to not add the type-parameter here as the other generic model validator type (`ModelAfterValidator`) consumes the type-parameter - and adding it indeed fixes the issue.
|
please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Since #7154,
ModelWrapValidatoris generic, and ifreportUnknownVariableTypeis enabled in Pyright the import will be a type-error. I think it was an oversight to not add the type-parameter here as the other generic model validator type (ModelAfterValidator) consumes the type-parameter - and adding it indeed fixes the issue.I think this doesn't need a new test as it's purely a type-level change.
Related issue number
Prior PR - #7154
Checklist
Selected Reviewer: @davidhewitt