Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type-error on model_validator in wrap mode #7496

Merged
merged 2 commits into from Sep 19, 2023
Merged

fix: type-error on model_validator in wrap mode #7496

merged 2 commits into from Sep 19, 2023

Commits on Sep 19, 2023

  1. fix: type-error on model_validator in wrap mode 

    Since #7154, `ModelWrapValidator` is generic, and if `reportUnknownVariableType` is enabled in Pyright the import will be a type-error. I think it was an oversight to not add the type-parameter here as the other generic model validator type (`ModelAfterValidator`) consumes the type-parameter - and adding it indeed fixes the issue.
    @pmmmwh
    pmmmwh committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    2627ef1 View commit details
    Browse the repository at this point in the history

  2. fix: linting

    @pmmmwh
    pmmmwh committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    8c79928 View commit details
    Browse the repository at this point in the history