Simplify flatteining and inlining of Coreschema

[adriangb]

Selected Reviewer: @davidhewitt

[cloudflare-pages]

Deploying with    Cloudflare Pages

Latest commit:	6d85d7c
Status:	✅  Deploy successful!
Preview URL:	https://b62189bd.pydantic-docs2.pages.dev
Branch Preview URL:	https://simplify-schema-flattening.pydantic-docs2.pages.dev

View logs

[adriangb]

please review

[davidhewitt]

It looks like the cause of this is that the following code is firing on this branch from _model_construction.py:

    if collect_invalid_schemas(schema):
        set_model_mocks(cls, cls_name)
        return False

I suggest we understand this further - smells like a possible bug.

[davidhewitt]

Let's xfail instead of modify, I will dig into this in parallel.

[JrooTJunior]

@dmontagu, @samuelcolvin, this changes breaks compatibility of https://github.com/aiogram/aiogram with pydantic 2.4

  File "/home/jrootjunior/work/aiogram/aiogram3/.hatch/dev/lib/python3.11/site-packages/pydantic/_internal/_core_utils.py", line 515, in count_refs
    recurse(state['definitions'][ref], count_refs)
            ~~~~~~~~~~~~~~~~~~~~^^^^^
KeyError: 'aiogram.types.input_text_message_content.InputTextMessageContent:94580207914144'

(full traceback)

You can check it by installing pip install aiogram==3.1.0 and then just import it - import aiogram.
I have temporary workaround - restrict to install pydantic 2.4 with aiogram, so, when you install pip install aiogram=3.1.1 and then import it - it works as well.

[davidhewitt]

Thanks for the report, we're investigating.