Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schema sorting bug with default values #7817

Merged
merged 1 commit into from Oct 13, 2023
Merged

Fix schema sorting bug with default values #7817

merged 1 commit into from Oct 13, 2023

Conversation

sydney-runkle
Copy link
Member

@sydney-runkle sydney-runkle commented Oct 13, 2023 •
edited

Change Summary

Fix bug where default values in json schema were sorted out of field order

Fix #7580

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

@sydney-runkle sydney-runkle mentioned this pull request Oct 13, 2023
Closed
5 tasks
@sydney-runkle sydney-runkle added the relnotes-fix Used for bugfixes. label Oct 13, 2023
@sydney-runkle
Copy link
Member Author

Please review 😄

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: faa970b
Status: ✅  Deploy successful!
Preview URL: https://618a9730.pydantic-docs2.pages.dev
Branch Preview URL: https://fix-schema-sorting-fields-bu.pydantic-docs2.pages.dev

View logs

@sydney-runkle sydney-runkle merged commit 2ace8cb into main Oct 13, 2023
61 of 62 checks passed
@sydney-runkle sydney-runkle deleted the fix-schema-sorting-fields-bug branch October 13, 2023 17:45
@LostInDarkMath LostInDarkMath mentioned this pull request Nov 21, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangb adriangb adriangb approved these changes

Assignees

@adriangb adriangb

Labels
ready for review relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Order of keys differs in schema output
2 participants
@sydney-runkle @adriangb