Improve warning message when a field name shadows a field in a parent model

[chan-vince]

Change Summary

Added in #7193, a helpful warning message is displayed when a subclass contains a field with the same name as the parent class.

If you have many models that inherit from a parent class, it would be helpful to be able to see in the warning message which child model contains the duplicate field name - not just the parent class.

So I've simply tweaked the warning message text to allow the user to easily see which model they should inspect.

Before:

UserWarning: Field name "foo" shadows an attribute in parent "ParentModel";

After:

UserWarning: Field name "foo" in "ChildModel" shadows an attribute in parent "ParentModel"

I think this is clearer for cases where you have tens or hundreds of ChildModels.

I also removed the semi-colon because I'm not sure why it's there, but happy to put that back, I may have missed a convention or other warning message or code style rule.

Related issue number

None

Checklist

• The pull request title is a good summary of the changes - it will be used in the changelog
• Unit tests for the changes exist
• Tests pass on CI
• Documentation reflects the changes where applicable
• My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @Kludex

[chan-vince]

please review

[codspeed-hq]

CodSpeed Performance Report

Merging #9105 will not alter performance

_{Comparing chan-vince:improve-user-warning-message (75a6f02) with main (af3d335)}

Summary

✅ 10 untouched benchmarks

[sydney-runkle]

Great work, thank you!